Skip to content

chore(ci): clean up workflow inputs and add iOS build number#28375

Merged
tommasini merged 5 commits into
mainfrom
chore/clean-up-new-workflows
Apr 3, 2026
Merged

chore(ci): clean up workflow inputs and add iOS build number#28375
tommasini merged 5 commits into
mainfrom
chore/clean-up-new-workflows

Conversation

@tommasini

@tommasini tommasini commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

Description

The upload-to-testflight.yml workflow had opaque summary_* prefixed inputs that made it hard to understand what each value represented. The build.yml workflow also lacked an iOS build number output, forcing callers to use the Android version code as a proxy.

This PR:

  • Renames summary_* inputs in upload-to-testflight.yml to clearer names (build_version, build_number, build_commit_sha, source_branch, build_branch)
  • Adds ios_version_code as a new output from build.yml, extracted from the Xcode project's CURRENT_PROJECT_VERSION
  • Updates all callers (build-and-upload-to-testflight.yml, runway-ota-build-core.yml) to use the renamed inputs
  • Removes a leftover debug step from runway-ota-build-core.yml
  • Removes redundant fallback defaults in the upload script call (callers already provide defaults)

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A — CI workflow changes only. Verify by triggering the build-and-upload-to-testflight or runway-ota-build-core workflows and checking that the step summary displays the correct build metadata fields.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
CI/release workflow wiring changed for TestFlight uploads and build metadata; mis-mapped inputs or parsing failures could break release automation even though no app runtime code is touched.

Overview
Simplifies the reusable upload-to-testflight.yml interface by replacing opaque summary_* inputs with explicit source_branch, build_branch, build_commit_sha, build_version, and build_number, and updates the step summary to match.

Extends build.yml to emit an ios_version_code output by parsing Xcode’s CURRENT_PROJECT_VERSION, and updates TestFlight callers (build-and-upload-to-testflight.yml, runway-ota-build-core.yml) to pass the new fields and use the iOS build number instead of Android’s.

Removes a debug step from runway-ota-build-core.yml and drops redundant default fallbacks when invoking scripts/upload-to-testflight.sh (workflow inputs already provide defaults).

Written by Cursor Bugbot for commit 08245a8. This will update automatically on new commits. Configure here.

@tommasini tommasini self-assigned this Apr 3, 2026
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 3, 2026
@github-actions github-actions Bot added the size-S label Apr 3, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 3, 2026
@tommasini tommasini marked this pull request as ready for review April 3, 2026 09:52
@tommasini tommasini requested review from a team as code owners April 3, 2026 09:52
@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 3, 2026

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@tommasini tommasini enabled auto-merge April 3, 2026 15:23
@tommasini tommasini added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed skip-e2e skip E2E test jobs skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. labels Apr 3, 2026

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk and removed risk-low Low testing needed · Low bug introduction risk labels Apr 3, 2026
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
All 4 changed files are purely CI/CD workflow files in .github/workflows/. The changes are:

  1. build.yml: Adds iOS version code (CURRENT_PROJECT_VERSION) extraction as a new workflow output, renames a variable for clarity.
  2. build-and-upload-to-testflight.yml: Refactors parameter names passed to upload-to-testflight.yml (summary_* prefix removed, source_branch/build_branch separated).
  3. runway-ota-build-core.yml: Removes debug logging steps, updates parameter names to match refactored upload-to-testflight.yml interface.
  4. upload-to-testflight.yml: Refactors input parameter names from summary_* convention to cleaner names, replaces android_version_code with ios build_number, removes fallback defaults.

These are purely build/release pipeline infrastructure changes with no application source code modifications. No E2E tests, no test infrastructure, no app functionality is affected. Running any E2E test tags would provide no validation value for these changes. No performance tests are needed either.

Performance Test Selection:
No application code changes were made. These are purely CI/CD workflow refactoring changes affecting build pipeline parameter naming and iOS version code extraction. No performance impact on the app.

View GitHub Actions results

@sonarqubecloud

sonarqubecloud Bot commented Apr 3, 2026

Copy link
Copy Markdown

@tommasini tommasini added this pull request to the merge queue Apr 3, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 3, 2026
Merged via the queue into main with commit 6334093 Apr 3, 2026
78 checks passed
@tommasini tommasini deleted the chore/clean-up-new-workflows branch April 3, 2026 16:52
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 3, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-S skip-e2e skip E2E test jobs skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants