Skip to content

chore(runway): cherry-pick fix: Remove Android access fine location from bluetooth library - cp-7.72.0#28404

Merged
tommasini merged 1 commit into
release/7.72.0from
runway-cherry-pick-7.72.0-1775465272
Apr 6, 2026
Merged

chore(runway): cherry-pick fix: Remove Android access fine location from bluetooth library - cp-7.72.0#28404
tommasini merged 1 commit into
release/7.72.0from
runway-cherry-pick-7.72.0-1775465272

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

Description

Remove Android access fine location from bluetooth library in an attempt
to resolve duplicate declaration error when uploading build to Google
play.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Low risk manifest-only change; main risk is unintended
removal/override of ACCESS_FINE_LOCATION affecting BLE behavior on
older Android versions if the merge rules don’t apply as expected.

Overview
Adjusts Android manifest BLE location permission declarations to avoid
Google Play upload failures caused by duplicate ACCESS_FINE_LOCATION
entries from dependency manifests.

Keeps a single uses-permission with android:maxSdkVersion="30" and
explicitly removes any uses-permission-sdk-23 variant via
tools:node="remove", while updating comments to document the merge
behavior.

Reviewed by Cursor Bugbot for commit
c34b584. Bugbot is set up for automated
code reviews on this repo. Configure
here.


Co-authored-by: tommasini tommasini15@gmail.com abac035

…rom bluetooth library - cp-7.72.0 (#28395)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Remove Android access fine location from bluetooth library in an attempt
to resolve duplicate declaration error when uploading build to Google
play.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Low risk manifest-only change; main risk is unintended
removal/override of `ACCESS_FINE_LOCATION` affecting BLE behavior on
older Android versions if the merge rules don’t apply as expected.
> 
> **Overview**
> Adjusts Android manifest BLE location permission declarations to avoid
Google Play upload failures caused by duplicate `ACCESS_FINE_LOCATION`
entries from dependency manifests.
> 
> Keeps a single `uses-permission` with `android:maxSdkVersion="30"` and
explicitly removes any `uses-permission-sdk-23` variant via
`tools:node="remove"`, while updating comments to document the merge
behavior.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
c34b584. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

---------

Co-authored-by: tommasini <tommasini15@gmail.com>
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Apr 6, 2026
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 97%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change to AndroidManifest.xml is a narrow Android manifest merge fix. It adds a uses-permission-sdk-23 element with tools:node="remove" for ACCESS_FINE_LOCATION to prevent Google Play Store from rejecting the app due to duplicate permission declarations from different dependencies (react-native-ble-plx and rxandroidble). This is purely a build/manifest configuration fix:

  1. No runtime behavior changes - the effective permissions granted to the app remain identical
  2. No UI changes, no controller changes, no functional code changes
  3. No impact on any E2E test flows (accounts, confirmations, swaps, networks, etc.)
  4. No performance implications
  5. The change only affects how the Android build tools merge manifest files from dependencies

This is a Google Play Store compliance fix that does not require any E2E test validation beyond what would normally be run in CI for Android builds.

Performance Test Selection:
The AndroidManifest.xml change is a manifest merge directive fix with no impact on app runtime performance. It does not affect UI rendering, data loading, app startup, or any user flows that would be measured by performance tests.

View GitHub Actions results

@github-actions github-actions Bot added risk-low Low testing needed · Low bug introduction risk size-XS labels Apr 6, 2026
@tommasini tommasini merged commit f848a59 into release/7.72.0 Apr 6, 2026
50 of 52 checks passed
@tommasini tommasini deleted the runway-cherry-pick-7.72.0-1775465272 branch April 6, 2026 09:07
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk-low Low testing needed · Low bug introduction risk size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants