Skip to content

fix: Remove Android access fine location from bluetooth library - cp-7.72.0#28395

Merged
tommasini merged 3 commits into
mainfrom
fix/android-fine-location-sdk-version
Apr 6, 2026
Merged

fix: Remove Android access fine location from bluetooth library - cp-7.72.0#28395
tommasini merged 3 commits into
mainfrom
fix/android-fine-location-sdk-version

Conversation

@Cal-L

@Cal-L Cal-L commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

Description

Remove Android access fine location from bluetooth library in an attempt to resolve duplicate declaration error when uploading build to Google play.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk manifest-only change; main risk is unintended removal/override of ACCESS_FINE_LOCATION affecting BLE behavior on older Android versions if the merge rules don’t apply as expected.

Overview
Adjusts Android manifest BLE location permission declarations to avoid Google Play upload failures caused by duplicate ACCESS_FINE_LOCATION entries from dependency manifests.

Keeps a single uses-permission with android:maxSdkVersion="30" and explicitly removes any uses-permission-sdk-23 variant via tools:node="remove", while updating comments to document the merge behavior.

Reviewed by Cursor Bugbot for commit c34b584. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Apr 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change team-accounts labels Apr 4, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 4, 2026
tommasini
tommasini previously approved these changes Apr 6, 2026
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 6, 2026
@github-actions github-actions Bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Apr 6, 2026
@tommasini tommasini enabled auto-merge April 6, 2026 08:17
@tommasini tommasini added skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. skip-e2e skip E2E test jobs labels Apr 6, 2026
@github-actions github-actions Bot removed the risk-low Low testing needed · Low bug introduction risk label Apr 6, 2026
@github-actions

github-actions Bot commented Apr 6, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change to AndroidManifest.xml is a pure build/packaging fix that:

  1. Adds a uses-permission-sdk-23 element with tools:node="remove" to remove a duplicate ACCESS_FINE_LOCATION permission declaration injected by the rxandroidble dependency.
  2. Updates a comment to better explain the BLE location permission conflict.

This is a manifest merger directive that only affects the Android build-time manifest merging process to prevent Google Play Store rejection due to duplicate permission declarations. It does NOT:

  • Change any app logic, UI components, or user flows
  • Affect any controller, engine, or state management
  • Impact navigation, modals, confirmations, or any E2E-testable behavior
  • Change the actual runtime permissions granted to the app (ACCESS_FINE_LOCATION is still limited to maxSdkVersion 30)

No E2E tests are needed as no user-facing functionality is changed. This is purely a build configuration fix for Play Store compliance.

Performance Test Selection:
This is a pure Android manifest build fix with no impact on app runtime performance, rendering, data loading, or any user flow timing. No performance tests are warranted.

View GitHub Actions results

@github-actions github-actions Bot added the risk-low Low testing needed · Low bug introduction risk label Apr 6, 2026

@ieow ieow left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sonarqubecloud

sonarqubecloud Bot commented Apr 6, 2026

Copy link
Copy Markdown

@tommasini tommasini added this pull request to the merge queue Apr 6, 2026
Merged via the queue into main with commit abac035 Apr 6, 2026
86 of 115 checks passed
@tommasini tommasini deleted the fix/android-fine-location-sdk-version branch April 6, 2026 08:45
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 6, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 6, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 6, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-XS skip-e2e skip E2E test jobs skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-accounts

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants