chore(runway): cherry-pick fix: Resolve fine location max sdk to app version's sdk - cp-7.72.0#28385
Conversation
…version's sdk - cp-7.72.0 (#28384) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR attempts to resolve the Android APK upload error for Playstore where it complains about duplicate ACCESS_FINE_LOCATION declarations (WRT to the bluetooth library) ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I've included tests if applicable - [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Low risk manifest-only change; adjusts permission merge behavior to satisfy Play Store validation, with limited runtime impact beyond how the permission is declared/merged. > > **Overview** > Resolves a Play Store upload failure caused by duplicate `ACCESS_FINE_LOCATION` declarations when merging manifests (e.g., from `react-native-ble-plx`). > > Updates `AndroidManifest.xml` to explicitly `tools:replace` the `android:maxSdkVersion` attribute on `ACCESS_FINE_LOCATION`, ensuring a single consistent declaration for Android < 12 Bluetooth-related location usage. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit ecb94e2. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Key observations:
Since this is purely a build tooling fix with no functional impact on the app, no E2E test tags need to be run. Performance Test Selection: |
|



Description
This PR attempts to resolve the Android APK upload error for Playstore
where it complains about duplicate ACCESS_FINE_LOCATION declarations
(WRT to the bluetooth library)
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Low Risk
Low risk manifest-only change; adjusts permission merge behavior to
satisfy Play Store validation, with limited runtime impact beyond how
the permission is declared/merged.
Overview
Resolves a Play Store upload failure caused by duplicate
ACCESS_FINE_LOCATIONdeclarations when merging manifests (e.g., fromreact-native-ble-plx).Updates
AndroidManifest.xmlto explicitlytools:replacetheandroid:maxSdkVersionattribute onACCESS_FINE_LOCATION, ensuring asingle consistent declaration for Android < 12 Bluetooth-related
location usage.
Written by Cursor
Bugbot for commit
ecb94e2. This will update automatically
on new commits. Configure
here.