Skip to content

fix: Resolve fine location max sdk to app version's sdk - cp-7.72.0#28384

Merged
Cal-L merged 1 commit into
mainfrom
fix/android-fine-location-sdk-version
Apr 3, 2026
Merged

fix: Resolve fine location max sdk to app version's sdk - cp-7.72.0#28384
Cal-L merged 1 commit into
mainfrom
fix/android-fine-location-sdk-version

Conversation

@Cal-L

@Cal-L Cal-L commented Apr 3, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

This PR attempts to resolve the Android APK upload error for Playstore where it complains about duplicate ACCESS_FINE_LOCATION declarations (WRT to the bluetooth library)

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Low risk manifest-only change; adjusts permission merge behavior to satisfy Play Store validation, with limited runtime impact beyond how the permission is declared/merged.

Overview
Resolves a Play Store upload failure caused by duplicate ACCESS_FINE_LOCATION declarations when merging manifests (e.g., from react-native-ble-plx).

Updates AndroidManifest.xml to explicitly tools:replace the android:maxSdkVersion attribute on ACCESS_FINE_LOCATION, ensuring a single consistent declaration for Android < 12 Bluetooth-related location usage.

Written by Cursor Bugbot for commit ecb94e2. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-mobile-platform Mobile Platform team label Apr 3, 2026
@Cal-L Cal-L added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change and removed team-mobile-platform Mobile Platform team labels Apr 3, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 3, 2026
@github-actions github-actions Bot added size-XS risk-low Low testing needed · Low bug introduction risk labels Apr 3, 2026
@github-actions

github-actions Bot commented Apr 3, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 88%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a single-line Android manifest fix that adds tools:replace="android:maxSdkVersion" to the ACCESS_FINE_LOCATION permission declaration. This resolves a manifest merge conflict with the react-native-ble-plx library (used by Ledger Bluetooth hardware wallet adapter). The fix is purely a build-time configuration change:

  1. No JavaScript/TypeScript code is modified
  2. No user-facing functionality changes
  3. No controller, engine, or state management affected
  4. The actual runtime permission behavior remains identical (ACCESS_FINE_LOCATION still restricted to maxSdkVersion="30")

The only functional area this could theoretically affect is Ledger hardware wallet Bluetooth connectivity on Android (since react-native-ble-plx is used by LedgerBluetoothAdapter). SmokeAccounts covers hardware wallet account flows (QR-based hardware wallet accounts) and is the most relevant tag to validate that the Bluetooth permission declaration still works correctly after the manifest merge fix.

No performance tests are needed as this is a manifest declaration change with no impact on rendering, data loading, or app performance.

Performance Test Selection:
This is a pure Android manifest declaration fix with no impact on UI rendering, data loading, state management, or any performance-sensitive code paths. No performance tests are warranted.

View GitHub Actions results

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 3, 2026
@Cal-L Cal-L merged commit 6baff38 into main Apr 3, 2026
100 of 102 checks passed
@Cal-L Cal-L deleted the fix/android-fine-location-sdk-version branch April 3, 2026 16:18
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 3, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 3, 2026
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 3, 2026
@metamaskbot metamaskbot added the release-7.74.0 Issue or pull request that will be included in release 7.74.0 label Apr 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

no changelog required No changelog entry is required for this change No QA Needed Apply this label when your PR does not need any QA effort. no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.74.0 Issue or pull request that will be included in release 7.74.0 risk-low Low testing needed · Low bug introduction risk size-XS team-accounts

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Cal-L @tommasini @metamaskbot