{
  "pr": "27906",
  "title": "Verify aggregated PnL and order size consistency across all trade history surfaces",
  "jira": "TAT-2483",
  "acceptance_criteria": [
    "Perp Market screen displays correct aggregated PnL and order size for multi-fill trades",
    "Perps Home screen recent activity shows identical aggregated values",
    "Activity page shows the same aggregated values as the other two surfaces",
    "Multi-fill trades (same orderId + timestamp) are properly aggregated, not collapsed by dedup"
  ],
  "validate": {
    "static": ["yarn lint:tsc"],
    "runtime": {
      "pre_conditions": ["wallet.unlocked", "perps.feature_enabled"],
      "steps": [
        {
          "id": "check_multi_fills_exist",
          "description": "Verify account has multi-fill trades (prerequisite for the bug)",
          "action": "eval_async",
          "expression": "Engine.context.PerpsController.getActiveProviderOrNull().getOrderFills({aggregateByTime: false}).then(function(fills) { var grouped = {}; fills.forEach(function(f) { var key = f.orderId + '_' + f.timestamp; if (!grouped[key]) grouped[key] = 0; grouped[key] = grouped[key] + 1; }); var multiCount = 0; Object.keys(grouped).forEach(function(k) { if (grouped[k] > 1) multiCount = multiCount + 1; }); return JSON.stringify({totalFills: fills.length, multiFillKeys: multiCount}); })",
          "assert": {
            "operator": "gt",
            "field": "multiFillKeys",
            "value": 0
          }
        },
        {
          "id": "verify_new_dedup_preserves_fills",
          "description": "Assert that the fixed dedup key (orderId+timestamp+size+price) preserves all fills - this fails with old key",
          "action": "eval_async",
          "expression": "Engine.context.PerpsController.getActiveProviderOrNull().getOrderFills({aggregateByTime: false}).then(function(fills) { var oldKeyMap = {}; var newKeyMap = {}; fills.forEach(function(f) { var oldKey = f.orderId + '_' + f.timestamp; var newKey = f.orderId + '_' + f.timestamp + '_' + f.size + '_' + f.price; oldKeyMap[oldKey] = f; newKeyMap[newKey] = f; }); var oldCount = Object.keys(oldKeyMap).length; var newCount = Object.keys(newKeyMap).length; return JSON.stringify({totalFills: fills.length, oldKeyUnique: oldCount, newKeyUnique: newCount, oldKeyLost: fills.length - oldCount, newKeyLost: fills.length - newCount}); })",
          "assert": {
            "operator": "eq",
            "field": "newKeyLost",
            "value": 0
          }
        },
        {
          "id": "nav_market_eth",
          "description": "Navigate to ETH market page (has multi-fill SL trades)",
          "action": "flow_ref",
          "ref": "market-discovery",
          "params": { "symbol": "ETH" }
        },
        {
          "id": "wait_market_render",
          "description": "Wait for trades list to render with REST fills",
          "action": "wait",
          "ms": 5000
        },
        {
          "id": "screenshot_market",
          "description": "Capture market trades list for visual review",
          "action": "screenshot",
          "filename": "market-trades-eth"
        },
        {
          "id": "nav_activity",
          "description": "Navigate to activity page trades tab",
          "action": "flow_ref",
          "ref": "activity-view",
          "params": { "tab": "trades" }
        },
        {
          "id": "wait_activity_render",
          "description": "Wait for activity data to load",
          "action": "wait",
          "ms": 3000
        },
        {
          "id": "screenshot_activity",
          "description": "Capture activity trades for visual comparison",
          "action": "screenshot",
          "filename": "activity-trades"
        }
      ]
    }
  }
}