fix: private key scroll by gantunesr · Pull Request #27891 · MetaMask/metamask-mobile

gantunesr · 2026-03-24T21:17:12Z

Description

Fix scroll in the "Private Key" list for Android devices

Changelog

CHANGELOG entry: fix scroll in the "Private Key" list for Android devices

Related issues

Fixes: #27192
Fixes: https://consensyssoftware.atlassian.net/browse/MUL-1552

Manual testing steps

Use a device/emulator with small screen
Go to the private key list
Try to scroll without dismissing the bottom sheet

Screenshots/Recordings

Before

Check #27192

After

Screen.Recording.2026-03-24.at.6.11.56.PM.mov

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Touches shared BottomSheet/BottomSheetDialog gesture handling by forwarding arbitrary PanGestureHandler props, which could subtly change swipe-to-dismiss behavior across consumers (especially on Android). Changes are localized but affect a common UI primitive.

Overview
Fixes Android scrolling in the Private Key list bottom sheet by allowing callers to pass PanGestureHandler configuration down into BottomSheetDialog and wiring PrivateKeyList to use simultaneousHandlers with the list’s RNGH ScrollView ref so scroll gestures don’t trigger sheet dismissal.

Updates/extends tests to cover the new panGestureHandlerProps plumbing and adds broader PrivateKeyList behavior assertions (error reset, banner content, cancel navigation, SOL-only filtering, and Android-specific rendering).

^{Written by Cursor Bugbot for commit f72fa25. This will update automatically on new commits. Configure here.}

…/metamask-mobile into gar/fix/private-keys-ux

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

codecov-commenter · 2026-03-27T18:25:34Z

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.63%. Comparing base (eb330c5) to head (60323bf).
⚠️ Report is 103 commits behind head on main.

Files with missing lines	Patch %	Lines
...ltichainAccounts/PrivateKeyList/PrivateKeyList.tsx	75.00%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #27891      +/-   ##
==========================================
+ Coverage   82.60%   82.63%   +0.03%     
==========================================
  Files        4839     4854      +15     
  Lines      124418   125103     +685     
  Branches    27726    27922     +196     
==========================================
+ Hits       102774   103378     +604     
- Misses      14580    14603      +23     
- Partials     7064     7122      +58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

georgewrmarshall

Hey @gantunesr, thanks for extending the functionality of the BottomSheetDialog. I was wondering if we can make this somewhat more future proofed to allow for all PanGestureHandler props via a prop object? Some of my code suggestions may be sudo-code and need formatting or testing.

@MetaMask/design-system-engineers we will need to do this to the MMDS version as well

gantunesr · 2026-03-31T11:18:26Z

The new introduced code is 100% tested

gantunesr · 2026-03-31T11:26:27Z

'BottomSheet' is deprecated.
Check warning: 'BottomSheet' is deprecated.

See more on https://sonarcloud.io/project/issues?id=metamask-mobile&issues=AZ0s1Zdt_bOZZnqPOCVa&open=AZ0s1Zdt_bOZZnqPOCVa&pullRequest=27891

The BottomSheet is not introduced in this PR, this can be ignored.

mathieuartu

Looks good, haven't tested

georgewrmarshall

LGTM! Approving on behalf of @MetaMask/design-system-engineers

Created same PR in MMDS

#27891

github-actions · 2026-04-01T12:05:52Z

🔍 Smart E2E Test Selection

Selected E2E tags: SmokeAccounts, SmokeWalletPlatform
Selected Performance tags: None (no tests recommended)
Risk Level: medium
AI Confidence: 82%

click to see 🤖 AI reasoning details

E2E Test Selection:
The PR makes two related changes:

BottomSheet/BottomSheetDialog (additive, backward-compatible): Adds an optional panGestureHandlerProps prop that is spread onto the underlying PanGestureHandler. This is a purely additive change — all existing consumers are unaffected since the prop defaults to undefined. No regression risk for the broad set of BottomSheet consumers (confirmations, wallet actions, SDK modals, etc.).
PrivateKeyList (Android gesture fix): Uses the new panGestureHandlerProps.simultaneousHandlers on Android to prevent the BottomSheet's pan gesture handler from capturing FlashList scroll gestures as dismiss-sheet pans. This is a targeted fix for the private key export flow in the MultichainAccounts feature.

The PrivateKeyList component is part of the multi-SRP/multichain accounts architecture, accessed via account action menus and the AccountGroupDetails screen. This directly maps to:

SmokeAccounts: Covers SRP export flows, private key export, account management, and the RevealPrivateCredential component. The PrivateKeyList is the core component being changed.
SmokeWalletPlatform: Covers multi-SRP wallet architecture, exporting SRP from Settings and account action menus, and managing separate account hierarchies per SRP.

No other tags are warranted since the BottomSheet change is non-breaking and additive, and the PrivateKeyList change is scoped to the private key/SRP export flow.

Performance Test Selection:
The changes are focused on gesture handling correctness (fixing an Android scroll/pan conflict) and adding an optional prop to BottomSheet. There are no changes to rendering performance, data loading, state management, or critical user flow timing. No performance tests are warranted.

View GitHub Actions results

github-actions · 2026-04-01T12:23:29Z

✅ E2E Fixture Validation — Schema is up to date
17 value mismatches detected (expected — fixture represents an existing user).
View details

sonarqubecloud · 2026-04-01T12:37:04Z

Quality Gate failed

Failed conditions
70.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

fix: private key scroll

1eedb29

gantunesr marked this pull request as ready for review March 24, 2026 21:17

gantunesr requested review from a team as code owners March 24, 2026 21:17

metamaskbot added the team-accounts-framework Accounts team label Mar 24, 2026

github-actions Bot added the size-S label Mar 24, 2026

cursor Bot reviewed Mar 24, 2026

View reviewed changes

Comment thread app/components/Views/MultichainAccounts/PrivateKeyList/PrivateKeyList.tsx Outdated

Merge branch 'main' into gar/fix/private-keys-ux

7e18416

github-actions Bot added the risk-medium Moderate testing recommended · Possible bug introduction risk label Mar 26, 2026

gantunesr added 2 commits March 26, 2026 13:33

chore: apply feebdack

c4293e1

Merge branch 'gar/fix/private-keys-ux' of https://github.com/MetaMask…

719c8ff

…/metamask-mobile into gar/fix/private-keys-ux

github-actions Bot added size-M risk-medium Moderate testing recommended · Possible bug introduction risk and removed size-S risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 27, 2026

cursor Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread .../components/BottomSheets/BottomSheet/foundation/BottomSheetDialog/BottomSheetDialog.test.tsx Outdated

Comment thread .../components/BottomSheets/BottomSheet/foundation/BottomSheetDialog/BottomSheetDialog.test.tsx Outdated

chore: apply feebdack

60323bf

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 27, 2026

cursor Bot reviewed Mar 27, 2026

View reviewed changes

Comment thread app/components/Views/MultichainAccounts/PrivateKeyList/PrivateKeyList.test.tsx

Comment thread app/components/Views/MultichainAccounts/PrivateKeyList/PrivateKeyList.test.tsx Outdated

gantunesr added 2 commits March 27, 2026 17:14

chore: apply feebdack

aca7436

test: toBeDefined -> toBeOnTheScreen

fdec13f

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 30, 2026

georgewrmarshall reviewed Mar 30, 2026

View reviewed changes

refactor: review feedback

5823464

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 30, 2026

gantunesr added the skip-e2e-flakiness-detection Skips the E2E flakiness detection (extra runs on new and modified E2E files) label Mar 31, 2026

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Mar 31, 2026

mathieuartu approved these changes Mar 31, 2026

View reviewed changes

georgewrmarshall approved these changes Apr 1, 2026

View reviewed changes

georgewrmarshall mentioned this pull request Apr 1, 2026

feat(react-native): add panGestureHandlerProps to BottomSheet MetaMask/metamask-design-system#1016

Merged

7 tasks

Merge branch 'main' into gar/fix/private-keys-ux

f72fa25

github-actions Bot added risk-medium Moderate testing recommended · Possible bug introduction risk and removed risk-medium Moderate testing recommended · Possible bug introduction risk labels Apr 1, 2026

gantunesr added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Apr 1, 2026

gantunesr added this pull request to the merge queue Apr 2, 2026

Merged via the queue into main with commit 4955891 Apr 2, 2026
168 of 174 checks passed

gantunesr deleted the gar/fix/private-keys-ux branch April 2, 2026 12:29

github-actions Bot locked and limited conversation to collaborators Apr 2, 2026

metamaskbot added the release-7.73.0 Issue or pull request that will be included in release 7.73.0 label Apr 2, 2026

Uh oh!

Conversation

gantunesr commented Mar 24, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Mar 27, 2026

Codecov Report

Uh oh!

georgewrmarshall left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gantunesr commented Mar 31, 2026

Uh oh!

gantunesr commented Mar 31, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mathieuartu left a comment

Choose a reason for hiding this comment

Uh oh!

georgewrmarshall left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 1, 2026

🔍 Smart E2E Test Selection

Uh oh!

github-actions Bot commented Apr 1, 2026

Uh oh!

sonarqubecloud Bot commented Apr 1, 2026

Quality Gate failed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gantunesr commented Mar 24, 2026 •

edited by cursor Bot

Loading

georgewrmarshall left a comment •

edited

Loading

gantunesr commented Mar 31, 2026 •

edited

Loading