Skip to content

chore(runway): cherry-pick chore: Market Insights design review cp-7.70.0#27498

Merged
chloeYue merged 1 commit into
release/7.70.0from
runway-cherry-pick-7.70.0-1773684406
Mar 17, 2026
Merged

chore(runway): cherry-pick chore: Market Insights design review cp-7.70.0#27498
chloeYue merged 1 commit into
release/7.70.0from
runway-cherry-pick-7.70.0-1773684406

Conversation

@runway-github

@runway-github runway-github Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

Description

Updates a few design elements In Market Insights.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Adds new Buy navigation and CAIP-asset parsing from Market Insights,
plus a react-native-video background; these touch navigation/asset-id
construction and could break CTAs or tests if ramp/swap inputs are
wrong.

Overview
Updates the Market Insights full-screen view to include an
auto-playing light/dark background video and replaces the single Trade
CTA with side-by-side Swap and Buy buttons. Swap interaction
tracking is renamed from trade to swap, and a new buy interaction
event is tracked; Buy routes through ramp navigation with best-effort
assetId derivation from the token address/chain.

Polishes several Market Insights components/styles (entry card
header/disclaimer layout, icon sizing, feedback copy/typography, bottom
sheet source list spacing) and tweaks behavior so tapping a source
closes the trend sources sheet. Tests and Jest config are updated
accordingly, including new mocks for .mp4 assets and
react-native-video.

Written by Cursor
Bugbot
for commit
d1e6ce2. This will update automatically
on new commits. Configure
here.

[dab238f](https://github.com/MetaMask/metamask-mobile/commit/dab238fe13bef1a0fb200c7b692e092e12a5e735)

…70.0 (#27259)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Updates a few design elements In Market Insights.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I've included tests if applicable
- [ ] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Adds new Buy navigation and CAIP-asset parsing from Market Insights,
plus a `react-native-video` background; these touch navigation/asset-id
construction and could break CTAs or tests if ramp/swap inputs are
wrong.
> 
> **Overview**
> Updates the Market Insights full-screen view to include an
auto-playing light/dark background video and replaces the single Trade
CTA with side-by-side **Swap** and **Buy** buttons. Swap interaction
tracking is renamed from `trade` to `swap`, and a new `buy` interaction
event is tracked; Buy routes through ramp navigation with best-effort
`assetId` derivation from the token address/chain.
> 
> Polishes several Market Insights components/styles (entry card
header/disclaimer layout, icon sizing, feedback copy/typography, bottom
sheet source list spacing) and tweaks behavior so tapping a source
closes the trend sources sheet. Tests and Jest config are updated
accordingly, including new mocks for `.mp4` assets and
`react-native-video`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
d1e6ce2. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Mar 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - base branch is not main (base: release/7.70.0)

All E2E tests pre-selected.

View GitHub Actions results

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown
Contributor

E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@chloeYue chloeYue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chloeYue chloeYue merged commit 71438cc into release/7.70.0 Mar 17, 2026
106 checks passed
@chloeYue chloeYue deleted the runway-cherry-pick-7.70.0-1773684406 branch March 17, 2026 09:04
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-L team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants