Skip to content

chore: Market Insights design review cp-7.70.0#27259

Merged
zone-live merged 20 commits into
mainfrom
TSA-design-qa-points
Mar 16, 2026
Merged

chore: Market Insights design review cp-7.70.0#27259
zone-live merged 20 commits into
mainfrom
TSA-design-qa-points

Conversation

@zone-live

@zone-live zone-live commented Mar 10, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Updates a few design elements In Market Insights.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds new Buy navigation and CAIP-asset parsing from Market Insights, plus a react-native-video background; these touch navigation/asset-id construction and could break CTAs or tests if ramp/swap inputs are wrong.

Overview
Updates the Market Insights full-screen view to include an auto-playing light/dark background video and replaces the single Trade CTA with side-by-side Swap and Buy buttons. Swap interaction tracking is renamed from trade to swap, and a new buy interaction event is tracked; Buy routes through ramp navigation with best-effort assetId derivation from the token address/chain.

Polishes several Market Insights components/styles (entry card header/disclaimer layout, icon sizing, feedback copy/typography, bottom sheet source list spacing) and tweaks behavior so tapping a source closes the trend sources sheet. Tests and Jest config are updated accordingly, including new mocks for .mp4 assets and react-native-video.

Written by Cursor Bugbot for commit d1e6ce2. This will update automatically on new commits. Configure here.

@zone-live zone-live added the team-social-ai Social & AI team label Mar 10, 2026
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor[bot]
cursor Bot reviewed Mar 10, 2026
View reviewed changes
Comment thread app/components/UI/MarketInsights/components/MarketInsightsTrendSourcesBottomSheet.tsx Outdated
@github-actions github-actions Bot added size-L and removed size-M labels Mar 10, 2026
cursor[bot]
cursor Bot reviewed Mar 10, 2026
View reviewed changes
Comment thread app/components/UI/MarketInsights/Views/MarketInsightsView/MarketInsightsView.tsx
@zone-live zone-live changed the title chore: Market Insights design review chore: Market Insights design review cp-7.69.0 Mar 10, 2026
@zone-live zone-live enabled auto-merge March 11, 2026 07:54
joaosantos15
joaosantos15 previously requested changes Mar 11, 2026
View reviewed changes

@joaosantos15 joaosantos15 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, but hold for now because we're reviewing the animation :)

@aganglada aganglada changed the title chore: Market Insights design review cp-7.69.0 chore: Market Insights design review Mar 11, 2026
@codecov-commenter

codecov-commenter commented Mar 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.19%. Comparing base (6b4798f) to head (d1e6ce2).
⚠️ Report is 118 commits behind head on main.

Files with missing lines Patch % Lines
...mponents/MarketInsightsTrendSourcesBottomSheet.tsx 56.25% 1 Missing and 6 partials ⚠️
...ts/Views/MarketInsightsView/MarketInsightsView.tsx 72.22% 2 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #27259      +/-   ##
==========================================
+ Coverage   81.97%   82.19%   +0.21%     
==========================================
  Files        4699     4747      +48     
  Lines      122881   123227     +346     
  Branches    27126    27263     +137     
==========================================
+ Hits       100737   101289     +552     
+ Misses      15167    14954     -213     
- Partials     6977     6984       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zone-live zone-live changed the title chore: Market Insights design review chore: Market Insights design review cp-7.70.0 Mar 16, 2026
cursor[bot]
cursor Bot reviewed Mar 16, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/components/UI/MarketInsights/Views/MarketInsightsView/MarketInsightsView.tsx
@MetaMask MetaMask deleted a comment from sonarqubecloud Bot Mar 16, 2026
@github-actions

github-actions Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
All changes are isolated to the MarketInsights UI module under app/components/UI/MarketInsights, including view components, bottom sheets, entry cards, animations (mp4 assets), test IDs, and related unit tests. MarketInsights appears to be part of the Trending/Discovery surface within the wallet. SmokeWalletPlatform explicitly covers the Trending discovery tab, including embedded sections and content feed browsing. Since these changes modify UI components and assets rendered within that area, SmokeWalletPlatform should be executed to validate navigation, rendering, and integration within the Trending tab.

There are no changes to controllers, Engine, confirmations, transactions, network permissions, swaps, perps, predictions transaction flows, or account management. Therefore, other tags such as SmokeConfirmations, SmokeTrade, SmokePerps, SmokePredictions, SmokeAccounts, SmokeNetworkAbstractions, etc., are not required.

jest.config.js and mocks updates affect unit testing and media handling but do not impact E2E runtime flows directly.

Thus, running SmokeWalletPlatform provides sufficient coverage with minimal unnecessary test execution.

Performance Test Selection:
Although MarketInsights includes new UI components and background video assets, there are no changes to core rendering infrastructure, account lists, swaps, onboarding, login, perps, or prediction performance-critical flows. No controllers, state management, or heavy list virtualization logic were modified. Therefore, performance test suites are not required.

View GitHub Actions results

@zone-live zone-live dismissed joaosantos15’s stale review March 16, 2026 16:43

Needs to be merged now for the nightly build.

@github-actions

github-actions Bot commented Mar 16, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
16 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

sonarqubecloud Bot commented Mar 16, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
84.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zone-live zone-live added this pull request to the merge queue Mar 16, 2026
Merged via the queue into main with commit dab238f Mar 16, 2026
98 checks passed
@zone-live zone-live deleted the TSA-design-qa-points branch March 16, 2026 17:59
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 16, 2026
@metamaskbot metamaskbot added the release-7.71.0 Issue or pull request that will be included in release 7.71.0 label Mar 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@joaosantos15 joaosantos15 joaosantos15 approved these changes

Assignees

No one assigned

Labels

release-7.71.0 Issue or pull request that will be included in release 7.71.0 size-L team-social-ai Social & AI team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zone-live @codecov-commenter @joaosantos15 @metamaskbot