Skip to content

fix: swaps network selector not scrolling on android cp-7.69.0#27295

Merged
infiniteflower merged 2 commits into
mainfrom
swaps-4252-fix-network-scroll
Mar 10, 2026
Merged

fix: swaps network selector not scrolling on android cp-7.69.0#27295
infiniteflower merged 2 commits into
mainfrom
swaps-4252-fix-network-scroll

Conversation

@infiniteflower

@infiniteflower infiniteflower commented Mar 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

The "Select Network" bottom sheet in the Bridge token selector was not scrollable on Android.

Tested on both iOS and Android.

Changelog

CHANGELOG entry: Fixed the Bridge "Select Network" bottom sheet not being scrollable when many networks are available on Android.

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/SWAPS-4252
Fixes: #27290

Manual testing steps

Feature: Bridge token selector network filter

  Scenario: user scrolls the network list in the Select Network bottom sheet
    Given the user is on the Bridge screen
    And many networks are available

    When user taps the network filter pill above the token list
    Then the Select Network bottom sheet opens

    When user attempts to scroll the network list
    Then the list scrolls smoothly without dismissing the sheet

    When user taps a network
    Then the sheet closes and the token list is filtered to that network

Screenshots/Recordings

Before

After

Screen.Recording.2026-03-10.at.5.07.59.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Small UI gesture-handling change limited to the Bridge network selector; no auth, security, or data-flow logic is modified.

Overview
Fixes the Bridge token selector "Select Network" bottom sheet not scrolling on Android by switching the network list container to ScrollView from react-native-gesture-handler, which correctly handles scroll gestures inside the bottom sheet.

Removes the unused BridgeNetworkSelectorBase component that previously wrapped children in a bottom sheet + react-native ScrollView.

Written by Cursor Bugbot for commit d3b24db. This will update automatically on new commits. Configure here.

@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added team-swaps-and-bridge Swaps and Bridge team INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Mar 10, 2026
@infiniteflower infiniteflower marked this pull request as ready for review March 10, 2026 21:19
@infiniteflower infiniteflower requested a review from a team as a code owner March 10, 2026 21:19
@github-actions github-actions Bot added size-S and removed size-XS labels Mar 10, 2026
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeTrade, SmokeConfirmations
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
The changes are limited to Bridge-related UI components: BridgeNetworkSelectorBase.tsx and BridgeTokenSelector/NetworkListModal.tsx. These components are part of the cross-chain bridge flow accessed via the Trade wallet actions menu.

Bridge functionality is explicitly covered under SmokeTrade (cross-chain bridging between networks). Since bridge flows require transaction confirmations, SmokeConfirmations must also be selected as per the tag dependency rules.

There are no changes to core Engine, controllers, network permissions, or multi-chain session APIs—only UI components within the Bridge feature—so broader tags like SmokeNetworkAbstractions, SmokeMultiChainAPI, or SmokeNetworkExpansion are not required.

Given that this affects a user-facing transaction flow (bridge network selection), running the bridge and confirmation tests is necessary to safely validate behavior with minimal scope expansion.

Performance Test Selection:
The changes are limited to UI components for network selection within the Bridge flow and do not modify rendering-heavy lists, controllers, data loading logic, or app initialization. There is no indication of changes that would impact app launch, login, account list rendering, asset loading, or swap performance. Therefore, no performance test tags are required.

View GitHub Actions results

@infiniteflower infiniteflower changed the title fix: swaps network selector not scrolling on android fix: swaps network selector not scrolling on android cp-7.69.0 Mar 10, 2026
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

✅ E2E Fixture Validation — Schema is up to date
11 value mismatches detected (expected — fixture represents an existing user).
View details

@sonarqubecloud

sonarqubecloud Bot commented Mar 10, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@infiniteflower infiniteflower added this pull request to the merge queue Mar 10, 2026
Merged via the queue into main with commit c22e473 Mar 10, 2026
111 checks passed
@infiniteflower infiniteflower deleted the swaps-4252-fix-network-scroll branch March 10, 2026 22:06
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 10, 2026
@metamaskbot metamaskbot added the release-7.70.0 Issue or pull request that will be included in release 7.70.0 label Mar 10, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@SteP-n-s SteP-n-s SteP-n-s approved these changes

Assignees

No one assigned

Labels

release-7.70.0 Issue or pull request that will be included in release 7.70.0 size-S team-swaps-and-bridge Swaps and Bridge team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Android Swaps Select Network is not scrollable

3 participants

@infiniteflower @SteP-n-s @metamaskbot