Skip to content

feat: stocks section in explore cp-7.68.0#26426

Merged
juanmigdr merged 23 commits into
mainfrom
feat/stcoks-section-in-explore
Mar 2, 2026
Merged

feat: stocks section in explore cp-7.68.0#26426
juanmigdr merged 23 commits into
mainfrom
feat/stcoks-section-in-explore

Conversation

@juanmigdr

@juanmigdr juanmigdr commented Feb 23, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Member

Description

This PR aims to add the stocks section in the explore page. In order to get this PR to the finish line, I have:

Changelog

CHANGELOG entry: added stocks section to explore page

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/ASSETS-2635 & https://consensyssoftware.atlassian.net/browse/ASSETS-2632

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Here is a full video explaining the e2e functionality.

Screen.Recording.2026-02-27.at.15.04.31.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Medium Risk
Adds a new Explore section and full-screen view backed by a new search hook with geo-restriction logic and new navigation routes, which could affect what data users see and how filtering/refetch behaves. Refactors Trending Tokens full view into shared layout/components, so regressions could impact existing trending-token filtering UI and bottom sheets.

Overview
Adds a new Stocks section to Explore, including a new RWATokensFullView screen/route and useRwaTokens hook that queries Ondo RWA assets (with production geo-blocking) and supports search, network, and sort filters.

Refactors TrendingTokensFullView into the UI/Trending area and introduces shared TokenListPageLayout, FilterBar, and useTokenListFilters to unify header/search/filter behavior across token list full views; updates the network bottom sheet to take an explicit networks prop and adjusts token sorting to push missing market data to the end. Explore/QuickActions/predictions presentation, navigation, mocks, and smoke tests are updated to include the new Stocks section and new predictions row rendering.

Written by Cursor Bugbot for commit 2be0c5a. This will update automatically on new commits. Configure here.

@juanmigdr juanmigdr changed the title Feat/stcoks section in explore feat: stocks section in explore Feb 23, 2026
@sonarqubecloud

sonarqubecloud Bot commented Feb 24, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@juanmigdr juanmigdr marked this pull request as ready for review February 25, 2026 09:40
@juanmigdr juanmigdr requested a review from a team as a code owner February 25, 2026 09:40
cursor[bot]
cursor Bot reviewed Feb 25, 2026
View reviewed changes
Comment thread app/components/UI/Trending/Views/RWATokensFullView/RWATokensFullView.tsx
cursor[bot]
cursor Bot reviewed Feb 27, 2026
View reviewed changes
Comment thread app/components/UI/Trending/Views/RWATokensFullView/RWATokensFullView.tsx
Comment thread app/components/Nav/Main/MainNavigator.js
@juanmigdr juanmigdr requested a review from a team as a code owner February 27, 2026 16:11
@juanmigdr juanmigdr changed the title feat: stocks section in explore feat: stocks section in explore cp-7.68.0 Feb 27, 2026
@juanmigdr juanmigdr enabled auto-merge February 27, 2026 16:12
cursor[bot]
cursor Bot reviewed Feb 27, 2026
View reviewed changes
Comment thread app/components/UI/Trending/hooks/useTrendingSearch/useTrendingSearch.ts Outdated
@juanmigdr juanmigdr force-pushed the feat/stcoks-section-in-explore branch from d062927 to 13e9d5d Compare February 27, 2026 17:54
@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR adds a new "Stocks" (RWA - Real World Assets) section to the Trending feature in MetaMask Mobile. The changes are well-scoped to the Trending/Explore functionality:

Key Changes:

  1. New RWATokensFullView screen for displaying RWA/Stock tokens
  2. New useRwaTokens hook with geo-restriction support for Ondo tokens
  3. New shared components (TokenListPageLayout, FilterBar, useTokenListFilters)
  4. Updated sections.config.tsx to add "stocks" section and reorder sections
  5. New navigation route RWA_TOKENS_FULL_VIEW
  6. Updated E2E tests (trending-feed.spec.ts) to include Stocks section testing

Why SmokeWalletPlatform:

  • The Trending tab is explicitly covered by SmokeWalletPlatform tag
  • The tag description states: "Trending is the connecting point for all subsections—changes to Perps, Predictions, or Tokens views (headers, lists, full views) that are embedded in Trending affect this tag"
  • The E2E tests in tests/smoke/trending/ are tagged with SmokeWalletPlatform

Why not other tags:

  • SmokePredictions: While predictions section order changed, no functional changes to predictions
  • SmokePerps: While perps section order changed, no functional changes to perps
  • SmokeConfirmations: No changes to transaction/signature confirmation flows
  • SmokeAccounts/SmokeIdentity: No changes to account management
  • SmokeTrade: No changes to swap/bridge flows
  • Other tags: No relevant changes

The changes are isolated to the Trending feature and don't affect other wallet functionality. The E2E test infrastructure has been properly updated to test the new Stocks section.

Performance Test Selection:
The changes add a new Stocks/RWA section to the Trending feature but don't significantly impact performance-critical paths. The new RWATokensFullView uses the same patterns as existing TrendingTokensFullView. The useRwaTokens hook uses existing search infrastructure. No changes to: app startup/launch, login flow, account list rendering, swap flows, or asset loading patterns. The changes are primarily UI additions and reorganization rather than performance-impacting modifications.

View GitHub Actions results

cursor[bot]
cursor Bot reviewed Feb 27, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Comment thread app/components/UI/Trending/hooks/useRwaTokens/useRwaTokens.ts
christopherferreira9
christopherferreira9 approved these changes Mar 2, 2026
View reviewed changes

@christopherferreira9 christopherferreira9 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for QA

Prithpal-Sooriya
Prithpal-Sooriya approved these changes Mar 2, 2026
View reviewed changes

@Prithpal-Sooriya Prithpal-Sooriya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally LGTM

@juanmigdr juanmigdr added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit f8c1bda Mar 2, 2026
94 of 95 checks passed
@juanmigdr juanmigdr deleted the feat/stcoks-section-in-explore branch March 2, 2026 11:31
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 2, 2026
@metamaskbot metamaskbot added the release-7.69.0 Issue or pull request that will be included in release 7.69.0 label Mar 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@bergarces bergarces bergarces approved these changes

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@salimtb salimtb salimtb approved these changes

@tommasini tommasini tommasini approved these changes

@christopherferreira9 christopherferreira9 christopherferreira9 approved these changes

Assignees

No one assigned

Labels

release-7.69.0 Issue or pull request that will be included in release 7.69.0 size-XL team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@juanmigdr @bergarces @Prithpal-Sooriya @salimtb @tommasini @christopherferreira9 @metamaskbot