Skip to content

feat: add corporate fare icon#26492

Merged
georgewrmarshall merged 3 commits into
mainfrom
corporate-fare-icon
Feb 24, 2026
Merged

feat: add corporate fare icon#26492
georgewrmarshall merged 3 commits into
mainfrom
corporate-fare-icon

Conversation

@georgewrmarshall

@georgewrmarshall georgewrmarshall commented Feb 24, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Adds the corporate-fare SVG icon to the Icon component library. This icon is needed to unblock the Stocks feature while we wait for the design system libraries upgrade in #26450.

Changelog

CHANGELOG entry: null

Related issues

Fixes: N/A
Related: #26450

Manual testing steps

Feature: Corporate Fare Icon

  Scenario: Icon renders correctly
    Given the app is running

    When a component references the corporate-fare icon
    Then the icon should render as a building/corporate symbol

Screenshots/Recordings

Before

N/A - new icon asset

After

N/A - SVG asset only, no UI change

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Adds a new static SVG and enum entry with no behavioral changes beyond making an additional icon available.

Overview
Adds a new corporate-fare.svg asset and exposes it through the Icon component library by extending IconName with CorporateFare and registering the asset in Icon.assets.ts.

Written by Cursor Bugbot for commit c78eb70. This will update automatically on new commits. Configure here.

@georgewrmarshall georgewrmarshall requested a review from a team as a code owner February 24, 2026 17:13
@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-design-system All issues relating to design system in Mobile label Feb 24, 2026
@georgewrmarshall georgewrmarshall self-assigned this Feb 24, 2026
@github-actions

github-actions Bot commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 95%
click to see 🤖 AI reasoning details

E2E Test Selection:
This PR adds a new icon asset (CorporateFare) to the Icon component library. The changes are purely additive:

  1. A new SVG file (corporate-fare.svg) is added
  2. The SVG is imported in Icon.assets.ts
  3. A new enum value CorporateFare is added to IconName in Icon.types.ts

The new icon is not used anywhere in the codebase yet - it's simply being added to the icon library for future use. No existing functionality is modified, no existing icons are changed, and no code paths are affected. This is a standard pattern for adding new icons to the component library.

Since this is a purely additive change with no impact on existing functionality, no E2E tests are required.

Performance Test Selection:
This change only adds a new icon asset to the component library. It does not affect UI rendering performance, data loading, state management, or any critical user flows. The new icon is not even used anywhere in the application yet. No performance impact is expected.

View GitHub Actions results

@codecov-commenter

codecov-commenter commented Feb 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.32%. Comparing base (d9d4b64) to head (c78eb70).
⚠️ Report is 72 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #26492    +/-   ##
========================================
  Coverage   81.32%   81.32%            
========================================
  Files        4487     4493     +6     
  Lines      116867   117127   +260     
  Branches    25295    25364    +69     
========================================
+ Hits        95039    95253   +214     
- Misses      15179    15200    +21     
- Partials     6649     6674    +25

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@georgewrmarshall georgewrmarshall added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Feb 24, 2026
@georgewrmarshall

georgewrmarshall commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

Skipping sonar cloud because the job is failing not an issue with code quality

Screenshot 2026-02-24 at 12 35 30 PM

@georgewrmarshall georgewrmarshall added this pull request to the merge queue Feb 24, 2026
Merged via the queue into main with commit 7e7a5e5 Feb 24, 2026
138 of 144 checks passed
@georgewrmarshall georgewrmarshall deleted the corporate-fare-icon branch February 24, 2026 20:56
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 24, 2026
@metamaskbot metamaskbot added the release-7.68.0 Issue or pull request that will be included in release 7.68.0 label Feb 24, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@amandaye0h amandaye0h amandaye0h approved these changes

Assignees

@georgewrmarshall georgewrmarshall

Labels

release-7.68.0 Issue or pull request that will be included in release 7.68.0 size-XS skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-design-system All issues relating to design system in Mobile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@georgewrmarshall @codecov-commenter @amandaye0h @metamaskbot