Skip to content

Fix analytics try catch#2546

Merged
andrepimenta merged 5 commits intodevelopfrom
fix/analytics-try-catch
Apr 19, 2021
Merged

Fix analytics try catch#2546
andrepimenta merged 5 commits intodevelopfrom
fix/analytics-try-catch

Conversation

@andrepimenta
Copy link
Copy Markdown
Member

Description

Fixes try catch on analytics log.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@andrepimenta andrepimenta requested a review from a team as a code owner April 19, 2021 14:34
CHANGELOG.md Outdated
@@ -1,6 +1,8 @@
# Changelog

## Current Develop Branch
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the version is missing here

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v2.2.0 - Apr 21 2021

maybe

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

Copy link
Copy Markdown
Contributor

@estebanmino estebanmino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@andrepimenta andrepimenta merged commit 658e3b1 into develop Apr 19, 2021
@andrepimenta andrepimenta deleted the fix/analytics-try-catch branch April 19, 2021 15:43
rickycodes added a commit to ScreamingHawk/metamask-mobile that referenced this pull request Apr 30, 2021
…tch-1

* 'develop' of github.com:MetaMask/metamask-mobile: (51 commits)
  Feature/confusables (MetaMask#2464)
  fix typeface on login text field (MetaMask#2610)
  Replace controller context (MetaMask#2416)
  Fix adding custom token in custom network (MetaMask#2590)
  only add custom tokens if not in mainnet (MetaMask#2470)
  Address yarn lints (MetaMask#2524)
  Upgrade .nvmrc to node v14 (MetaMask#2588)
  Swaps: Add cache thresholds configuration (MetaMask#2514)
  Swaps: BSC Support (MetaMask#2468)
  Use node 14 (MetaMask#2539)
  resolve isENS without case sensitivity (MetaMask#2545) (MetaMask#2568)
  Revert "resolve isENS without case sensitivity (MetaMask#2545)" (MetaMask#2566)
  resolve isENS without case sensitivity (MetaMask#2545)
  Bump versioncode (MetaMask#2558)
  v2.2.0 (MetaMask#2555)
  Include decimalsToShow in balanceToFiatNumber (MetaMask#2547)
  Bug fix/sync import time (MetaMask#2554)
  bundle update (MetaMask#2549)
  Fix analytics try catch (MetaMask#2546)
  Only get nonce from the network if the feature is enabled (MetaMask#2543)
  ...
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* Fix analytics try catch

* Move analytics on watch asset to line below

* Update changelog and bump version

* Fix version on changelog

* Mock InteractionManager
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants