Closed
Conversation
* develop: Bump vm-browserify from 0.0.4 to 1.1.2 (#2447) Bump jest-serializer from 24.4.0 to 26.6.2 (#2501) Bump react-native-share from 3.3.2 to 5.2.2 (#2499) Bump json-rpc-middleware-stream from 2.1.1 to 3.0.0 (#2411) Bump eslint-plugin-prettier from 3.3.0 to 3.3.1 (#2406) Bump babel-eslint from 10.0.3 to 10.1.0 (#2403) Display correct number of decimals for 'usd' fiat (#2381) bugfix/4849 (#2491) bugfix/2488 (#2490) Fix/analytics v1 priority1 (#2487) Add scripts for generating and verifying SHA 512 checksums (#2168)
* bugfix/address-yarn-lints: address yarn lints
… into feature/node-14 * 'feature/node-14' of github.com:MetaMask/metamask-mobile: rename master to main (#2493)
Merged
Contributor
Author
|
closing for now in favor of opening two PRs... one for the node upgrade the other for RN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a PR that gets us updated from node 10 to 14. It also updates react and react-native to latest (17.0.1, 0.64.0 respectively).
Leaving as a draft for now as I am still seeing some node-gyp errors locally... even though the app appears to run/build fine?
Also leaving hermes disabled for now as it was mentioned that performance is degraded when it's switched on (I haven't tested this myself).
Looking at this more closely it also seems like the upgrade broke tests. digging into that nowtests are working now :)
Checklist
Issue
Resolves #2205