Display correct number of decimals for 'usd' fiat#2381
Merged
rickycodes merged 3 commits intodevelopfrom Apr 12, 2021
Merged
Conversation
toFixed(2)
Contributor
Author
|
this is probably fine to merge as we're doing the same thing in other places (it only fixes the issue for USD) |
andrepimenta
requested changes
Apr 12, 2021
688db9a to
44cbef1
Compare
rickycodes
added a commit
that referenced
this pull request
Apr 13, 2021
* develop: Bump vm-browserify from 0.0.4 to 1.1.2 (#2447) Bump jest-serializer from 24.4.0 to 26.6.2 (#2501) Bump react-native-share from 3.3.2 to 5.2.2 (#2499) Bump json-rpc-middleware-stream from 2.1.1 to 3.0.0 (#2411) Bump eslint-plugin-prettier from 3.3.0 to 3.3.1 (#2406) Bump babel-eslint from 10.0.3 to 10.1.0 (#2403) Display correct number of decimals for 'usd' fiat (#2381) bugfix/4849 (#2491) bugfix/2488 (#2490) Fix/analytics v1 priority1 (#2487) Add scripts for generating and verifying SHA 512 checksums (#2168)
rickycodes
added a commit
that referenced
this pull request
Jan 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed we're not rounding fiat correctly in some instances:
Before:
After:
This likely needs more work since I don't think adding. We could probably look at addingtoFixed(2)is an adequate enough solutionIntl.NumberFormatin the future.Adding theDONOTMERGElabel and moving this to Draft until we can land on a better solution.Checklist
Issue
Resolves #???