Skip to content

chore: resolve PR #24906 nitpicks#25064

Merged
gantunesr merged 6 commits intomainfrom
gar/chore/24906-nits
Jan 23, 2026
Merged

chore: resolve PR #24906 nitpicks#25064
gantunesr merged 6 commits intomainfrom
gar/chore/24906-nits

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Jan 22, 2026 •
edited by cursor bot
Loading

Description

This PR resolves the nitpicks from PR #24906.

Changelog

CHANGELOG entry: null

Related issues

Fixes: None

Manual testing steps

Not applicable

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Selector update

  • selectAccountGroupsByKeyringId now builds the wallet ID prefix using toMultichainAccountWalletId(keyringId) instead of a hardcoded entropy: string.

UI behavior

  • SRPListItem shows account group count using accountGroups.length; minor cleanup and JSDoc for AccountGroupItem.

Tests

  • Updated SRPListItem tests to use derived wallet IDs and account group names from mocks.
  • Multisrp selector tests adjusted to match new prefix logic and expanded to cover empty groups and resolved internal accounts.

Written by Cursor Bugbot for commit 2cec47f. This will update automatically on new commits. Configure here.

@gantunesr gantunesr mentioned this pull request Jan 22, 2026
Merged
7 tasks
@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Jan 22, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jan 22, 2026

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokeAccounts
  • Risk Level: low
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The PR contains refactoring changes to multi-SRP (Secret Recovery Phrase) related code:

  1. app/selectors/multisrp/index.ts: Changed selectAccountGroupsByKeyringId selector to use toMultichainAccountWalletId(keyringId) from @metamask/account-api instead of hardcoding entropy:${keyringId} prefix. This is a proper API usage refactoring that maintains the same functionality.

  2. app/components/UI/SRPListItem/SRPListItem.tsx: Minor cleanup - removed unused accountCount variable and added JSDoc comment. No functional changes.

  3. Test files: Updated to use consistent mock data variable naming.

The changes are low risk because:

  • They are pure refactoring with no functional changes
  • The selector logic remains equivalent (just using the proper API helper)
  • Unit tests are updated and passing
  • The component change is just removing dead code

Selected tags:

  • SmokeWalletPlatform: Directly covers multi-SRP functionality including e2e/specs/multisrp/add-account.spec.ts, e2e/specs/multisrp/export-srp-from-settings.spec.ts, and e2e/specs/multisrp/export-srp-from-account-actions.spec.ts which test the SRPListItem component and account selection flows.
  • SmokeAccounts: Covers SRP reveal flows and wallet details that may use the affected selectors indirectly through account management features.

View GitHub Actions results

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jan 22, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@gantunesr gantunesr added the no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed label Jan 22, 2026
@gantunesr gantunesr marked this pull request as ready for review January 22, 2026 21:47
@gantunesr gantunesr added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit d82ec08 Jan 23, 2026
102 checks passed
@gantunesr gantunesr deleted the gar/chore/24906-nits branch January 23, 2026 17:38
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2026
@metamaskbot metamaskbot added the release-7.64.0 Issue or pull request that will be included in release 7.64.0 label Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ccharly ccharly ccharly approved these changes

Assignees

No one assigned

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.64.0 Issue or pull request that will be included in release 7.64.0 size-S team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gantunesr @ccharly @metamaskbot