Skip to content

fix: fix account list in the reveal SRP flow#24906

Merged
gantunesr merged 6 commits intomainfrom
gar/fix/srp-reveal-account-list
Jan 21, 2026
Merged

fix: fix account list in the reveal SRP flow#24906
gantunesr merged 6 commits intomainfrom
gar/fix/srp-reveal-account-list

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Jan 19, 2026

Description

The account list displayed on the SRP reveal flow was outdated by showing the UI pre-BIP44. This PR updates the UI to show the correct multichain account list.

Changelog

CHANGELOG entry: Update SRP flow to display multichain accounts

Related issues

Fixes: #22950

Manual testing steps

  1. Import 2 or more SRPs
  2. Create multiple accounts for each SRP (3 or more)
  3. Go to the reveal SRP flow
  4. Check that the account name and icon is correct when toggling the "Show X accounts" option
  5. Check that the revealed SRP is the correct one

Screenshots/Recordings

Before

Check #22950

After

Simulator Screenshot - iPhone 15 Pro - 2026-01-19 at 16 52 06

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Updates SRP reveal to reflect multichain account model.

  • Replace per-address list with multichain accountGroups in SRPListItem; toggle shows group count and expands a FlatList of group names with avatars seeded by selectIconSeedAddressByAccountGroupId; add maxHeight to accountsList style
  • Add selectAccountGroupsByKeyringId selector and tests; integrate into SRPListItem
  • Make selectIconSeedAddressByAccountGroupId resilient (returns empty string when no accounts); adjust tests accordingly
  • Refresh tests for SRPListItem and AddNewAccount to assert group-based counts, rendering, and analytics

Written by Cursor Bugbot for commit 239b576. This will update automatically on new commits. Configure here.

@gantunesr gantunesr marked this pull request as ready for review January 20, 2026 14:39
cursor[bot]

This comment was marked as outdated.

@gantunesr gantunesr requested a review from a team as a code owner January 20, 2026 18:21
@github-actions
Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeWalletPlatform, SmokeAccounts
  • Risk Level: medium
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

The changes modify the SRPListItem component to use account groups (multichain accounts) instead of individual account addresses. This is a significant refactoring that affects:

  1. SRPListItem component: Now uses selectAccountGroupsByKeyringId selector and displays account groups instead of individual accounts. The component is used in AddNewAccount, SRPList, SelectSRP, WalletRecovery, and ProtectYourWallet views.

  2. New selector selectAccountGroupsByKeyringId: Added to multisrp selectors to filter account groups by keyring ID.

  3. Error handling change: selectIconSeedAddressByAccountGroupId now returns empty string instead of throwing when no accounts found - this is a defensive change that prevents crashes.

The E2E tests in e2e/specs/multisrp/ directly use SRPListItemComponent which references the test IDs from the modified component. These tests are tagged with SmokeWalletPlatform.

Additionally, SmokeAccounts should be run because:

  • The changes affect account management and display
  • Account groups are a core concept for multichain accounts
  • The selectors are used across multiple account-related views

The risk is medium because:

  • The changes are well-tested with unit tests
  • The component structure remains similar (still uses FlatList, same test IDs)
  • The error handling change is defensive (returns empty string instead of throwing)
  • However, the data source has fundamentally changed from individual accounts to account groups

View GitHub Actions results

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@ccharly ccharly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor suggestions + Tested, works fine 💪

@gantunesr gantunesr added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit ef874f0 Jan 21, 2026
92 checks passed
@gantunesr gantunesr deleted the gar/fix/srp-reveal-account-list branch January 21, 2026 16:04
@github-actions github-actions bot locked and limited conversation to collaborators Jan 21, 2026
@metamaskbot metamaskbot added the release-7.63.0 Issue or pull request that will be included in release 7.63.0 label Jan 21, 2026
@gantunesr
Copy link
Copy Markdown
Member Author

All nitpicks are resolved as part of: #25064

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.63.0 Issue or pull request that will be included in release 7.63.0 size-M team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Reveal SRP settings when multiple SRPs imported display Solana/Snap accounts

5 participants