fix: HWB197 (24544) fix ledger transaction speedup and cancel#24745
Merged
dawnseeker8 merged 17 commits intoFeb 20, 2026
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Akaryatrh
previously approved these changes
Jan 16, 2026
Akaryatrh
previously approved these changes
Jan 16, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24745 +/- ##
=======================================
Coverage 79.82% 79.83%
=======================================
Files 4200 4200
Lines 107434 107454 +20
Branches 22402 22411 +9
=======================================
+ Hits 85761 85786 +25
+ Misses 15652 15648 -4
+ Partials 6021 6020 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…fees. Update `useUnifiedTxActions` to conditionally use legacy gas price or EIP-1559 gas fee based on transaction type. Add tests to verify correct handling of legacy transactions for speed up and cancel actions.
- Implemented tests to ensure that the modal state is properly cleaned up when a user rejects a transaction on the Ledger modal for both speed up and cancel actions. - Updated the `onConfirmation` function to clean up modal state regardless of user confirmation, preventing stale state issues. - Enhanced test coverage for the `useUnifiedTxActions` hook to validate the expected behavior during rejection scenarios.
Akaryatrh
previously approved these changes
Jan 21, 2026
dawnseeker8
commented
Jan 22, 2026
dawnseeker8
commented
Jan 22, 2026
gantunesr
reviewed
Feb 4, 2026
gantunesr
reviewed
Feb 4, 2026
gantunesr
reviewed
Feb 4, 2026
Updated the gas fee parameter logic in the LedgerTransactionModal to prefer legacyGasFee for legacy transactions and fall back to eip1559GasFee for EIP-1559 transactions. This change simplifies the code and improves clarity. Additionally, updated test descriptions in useUnifiedTxActions.test.ts for better accuracy regarding legacy transaction handling.
Akaryatrh
previously approved these changes
Feb 12, 2026
PatrykLucka
reviewed
Feb 16, 2026
PatrykLucka
reviewed
Feb 16, 2026
PatrykLucka
reviewed
Feb 16, 2026
…ions Refactored the onSpeedUpCompleted and onCancelCompleted functions to use useCallback for better performance and to prevent unnecessary re-renders. Updated the signLedgerTransaction function to also utilize useCallback, ensuring it correctly references the new completion handlers. This change enhances the efficiency of the transaction handling logic in the UnifiedTransactionsView component.
Akaryatrh
approved these changes
Feb 18, 2026
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Tag Selection Rationale:
Not Selected:
The risk is medium because:
Performance Test Selection: |
|
PatrykLucka
approved these changes
Feb 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the ledger transaction speedup and cancel not able to run issue.
The root clause of this issue was caused by when we introduce the new unified transaction view and we forgot to check account is ledger devices or not, and didn't handle ledger differently because ledger require BLE approve to trigger the speed up and cancl transaction.
If you look at legacy behavior defined in
Transaction/index.jsfile which has this code to handle ledger device check and then do speedup and cancelChangelog
CHANGELOG entry: Modify
useUnifiedTxActions.tsto specially handle ledger transaction speed up and cancel transaction.Related issues
Fixes: #24544
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Medium Risk
Changes transaction replacement execution paths and fee parameter wiring for Ledger accounts, which can affect speed up/cancel behavior; coverage is improved with new unit tests but the flow is user-funds-adjacent.
Overview
Fixes unified transaction speed up and cancel for Ledger accounts by detecting Ledger keyring addresses and routing replacement transactions through
LedgerTransactionModal(BLE confirmation) instead of callingspeedUpTransaction/TransactionController.stopTransactiondirectly.Extends Ledger replacement parameters to support legacy
gasPriceaslegacyGasFee(in addition to EIP-1559 fees), passes the appropriate fee shape through the modal, and ensures modal state is cleaned up even when the user rejects on the Ledger confirmation screen. Adds comprehensive unit tests covering Ledger vs non-Ledger paths and legacy vs EIP-1559 fee handling.Written by Cursor Bugbot for commit fe13682. This will update automatically on new commits. Configure here.