Skip to content

Feature/tx local state logs#2460

Merged
sethkfman merged 44 commits intodevelopfrom
feature/tx-local-state-logs
Apr 16, 2021
Merged

Feature/tx local state logs#2460
sethkfman merged 44 commits intodevelopfrom
feature/tx-local-state-logs

Conversation

@sethkfman
Copy link
Copy Markdown
Contributor

Description

This is a feature to track the times that a user adds/creates/imports an account on the mobile app which then is used to display added/import time and local transaction history.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@sethkfman sethkfman requested a review from a team March 31, 2021 22:33
@sethkfman sethkfman added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 31, 2021
@sethkfman sethkfman marked this pull request as ready for review April 1, 2021 19:13
@sethkfman sethkfman requested a review from andrepimenta April 13, 2021 15:26
@omnat omnat added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Apr 15, 2021
@sethkfman sethkfman requested a review from andrepimenta April 16, 2021 03:02
Copy link
Copy Markdown
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Apr 16, 2021
Copy link
Copy Markdown
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed QA testing has been completed and passed and removed QA in Progress QA has started on the feature. labels Apr 16, 2021
@sethkfman sethkfman merged commit 194a185 into develop Apr 16, 2021
@sethkfman sethkfman deleted the feature/tx-local-state-logs branch April 16, 2021 18:11
@sethkfman sethkfman mentioned this pull request Apr 20, 2021
3 tasks
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
* added reducer to capture wallet import time and added list element to display import time

* added UI level features for import wallet display in transaciton

* update UI and import location

* added logic to track local tx and refactored added wallet view

* added code comments

* updated package.json

* added test controllers module

* updated add transaction for deeplink

* updated package and yarn

* updated unit tests

* updated importTime to work with controller updates

* updated yarn.lock

* updated unit tests

* updated snapshots

* snapshot update

* updated contoller related code for latest change

* update package.json with latest controller version

* updated yarn

* update package.json with develop

* updated yarn file to develops

* PR feedback

* snapshot updated

* return null if element cannot be rendered

* refactored account added time

* added tmethods to determine the time when a transaction should be flagged to dispaly the added account time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

next release QA Passed QA testing has been completed and passed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants