Skip to content

Add resolution for y18n#2445

Merged
rickycodes merged 2 commits into
developfrom
bugfix/update-y18n
Mar 30, 2021
Merged

Add resolution for y18n#2445
rickycodes merged 2 commits into
developfrom
bugfix/update-y18n

Conversation

@rickycodes

Copy link
Copy Markdown
Contributor

Description

the yarn audit scrip caught a vulnerability in y18n. this fixes that.

@rickycodes rickycodes requested a review from a team as a code owner March 29, 2021 19:06
@rickycodes rickycodes merged commit f656ac0 into develop Mar 30, 2021
@rickycodes rickycodes deleted the bugfix/update-y18n branch March 30, 2021 14:30
rickycodes added a commit that referenced this pull request Jan 31, 2022
Gudahtt added a commit that referenced this pull request Mar 1, 2024
This resolution was added in #2445 to update the package to resolve a
security advisory. The resolution wasn't really needed for the update;
effectively the resolution has only resulted in the package being
downgraded to v3.
@Gudahtt Gudahtt mentioned this pull request Mar 1, 2024
13 tasks
Gudahtt added a commit that referenced this pull request Mar 4, 2024
This resolution was added in #2445 to update the package to resolve a
security advisory. The resolution wasn't really needed for the update;
effectively the resolution has only resulted in the package being
downgraded to v3.
Gudahtt added a commit that referenced this pull request Mar 4, 2024
## **Description**

This resolution was added in #2445 to update the package to resolve a
security advisory. The resolution wasn't really needed for the update;
effectively the resolution has only resulted in the package being
downgraded to v3.

## **Related issues**

N/A

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

N/A

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've clearly explained what problem this PR is solving and how it
is solved.
- [x] I've linked related issues
- [x] I've included manual testing steps
- [x] I've included screenshots/recordings if applicable
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
- [x] I’ve properly set the pull request status:
  - [x] In case it's not yet "ready for review", I've set it to "draft".
- [x] In case it's "ready for review", I've changed it from "draft" to
"non-draft".

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants