chore(runway): cherry-pick refactor(card): sonarcloud maintainability issues#22268
Merged
joaoloureirop merged 1 commit intoNov 6, 2025
Merged
Conversation
… issues (#22221) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> This PR addresses several maintainability issues reported by SonarCloud: 🔗 [View related issues on SonarCloud](https://sonarcloud.io/project/issues?id=metamask-mobile&pullRequest=22058&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true) Additionally, it reverts a temporary workaround previously added for Android to prevent a crash occurring when users navigated through the KYC WebView. The root cause of the WebView crash has been resolved in a separate PR, making the temporary fix unnecessary. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: Reverted temporary workaround for KYC WebView crash (issue resolved in upstream fix). ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Refactors Card features: rewrites asset selection and balance logic, unifies KYC verification navigation to WebView, tightens onboarding routing, improves SDK/logging, and adds extensive tests. > > - **Card Home**: > - Add `enableCardAction` tests covering success/failure/loading paths; mock `Logger.log`. > - Log errors in `enableCardAction` catch. > - **Asset Selection Bottom Sheet**: > - Major refactor with helper utilities (network filtering, token mapping/deduping, CAIP handling, sorting by priority/allowance). > - Integrate balances via `useAssetBalances`; show allowance state text; improve list rendering and Solana footer. > - Preserve existing navigation and priority update, and allow Limited tokens to update priority directly. > - **Balances (`useAssetBalances`)**: > - Extract helpers; improve fiat calculation (market data, Solana rates, proportional fallback), normalization, and asset building. > - Update tests with extensive scenarios (enabled/limited/not-enabled, fallbacks, edge cases). > - **Onboarding/KYC**: > - Verify Identity: always navigate to WebView; simplify tests; add screen view metric. > - OnboardingNavigator: require `firstName` and `countryOfNationality` before address; update tests. > - Types: add `countryOfNationality` to `UserResponse`. > - **SDK**: > - Improve error logging/handling (external wallet details, provision card); simplify network-to-CAIP mapping; minor cleanup. > - **Priority/External Wallet Hooks**: > - Extract `determineAllowanceState`; use nullish coalescing where applicable; add tests for warnings and fetching behaviors. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 94c9b08. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
joaoloureirop
approved these changes
Nov 6, 2025
|
Collaborator
|
No release label on PR. Adding release label release-7.58.1 on PR, as PR was cherry-picked in branch 7.58.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR addresses several maintainability issues reported by SonarCloud:
🔗 View related issues on
SonarCloud
Additionally, it reverts a temporary workaround previously added for
Android to prevent a crash occurring when users navigated through the
KYC WebView.
The root cause of the WebView crash has been resolved in a separate PR,
making the temporary fix unnecessary.
Changelog
CHANGELOG entry: Reverted temporary workaround for KYC WebView crash
(issue resolved in upstream fix).
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Note
Unifies KYC to in-app WebView, refactors asset selection and balance/allowance calculations, tightens onboarding routing, enhances SDK logging, and adds extensive tests.
OnboardingNavigatornow requiresuser.countryOfNationalitybefore address; adds tests for new routing paths.VerifyIdentityalways navigates toCARD.ONBOARDING.WEBVIEW; removes platform-specific browser logic; updates tests.AssetSelectionBottomSheet.tsx):Limitedas delegated for priority updates.renderBottomSheetContent; preservesallowanceStatewhen updating priority.useAssetBalances.tsx):CardHome.tsx):enableCardActionlogs errors and shows toast; fetches token and opens selection when provisioned.useGetCardExternalWalletDetails: factors allowance-state calc; maps totals safely.useGetPriorityCardToken: minor robustness (nullish coalescing, warning flow); more tests.CardSDK.ts):UserResponseaddscountryOfNationality.Written by Cursor Bugbot for commit 1e1b50b. This will update automatically on new commits. Configure here.
a2bee21