Skip to content

chore(runway): cherry-pick refactor(card): sonarcloud maintainability issues#22268

Merged
joaoloureirop merged 1 commit into
release/7.58.1from
runway-cherry-pick-7.58.1-1762453296
Nov 6, 2025
Merged

chore(runway): cherry-pick refactor(card): sonarcloud maintainability issues#22268
joaoloureirop merged 1 commit into
release/7.58.1from
runway-cherry-pick-7.58.1-1762453296

Conversation

@runway-github

@runway-github runway-github Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Description

This PR addresses several maintainability issues reported by SonarCloud:
🔗 View related issues on
SonarCloud

Additionally, it reverts a temporary workaround previously added for
Android to prevent a crash occurring when users navigated through the
KYC WebView.
The root cause of the WebView crash has been resolved in a separate PR,
making the temporary fix unnecessary.

Changelog

CHANGELOG entry: Reverted temporary workaround for KYC WebView crash
(issue resolved in upstream fix).

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Unifies KYC to in-app WebView, refactors asset selection and balance/allowance calculations, tightens onboarding routing, enhances SDK logging, and adds extensive tests.

  • KYC/Onboarding:
    • Route: OnboardingNavigator now requires user.countryOfNationality before address; adds tests for new routing paths.
    • Verify: VerifyIdentity always navigates to CARD.ONBOARDING.WEBVIEW; removes platform-specific browser logic; updates tests.
  • Asset Selection (AssetSelectionBottomSheet.tsx):
    • Extracts helpers for Linea chain filtering, network processing, token mapping/deduping, address resolution, and sorting.
    • Filters by user location and optionally hides Solana; treats Limited as delegated for priority updates.
    • Refactors list rendering via renderBottomSheetContent; preserves allowanceState when updating priority.
  • Balances/Allowances (useAssetBalances.tsx):
    • Adds helpers for balance source selection, Solana/EVM fiat calc, proportional fiat fallback, and asset building.
    • Normalizes parsing/formatting and returns richer balance info; large test suite added covering edge cases.
  • Card Home (CardHome.tsx):
    • enableCardAction logs errors and shows toast; fetches token and opens selection when provisioned.
    • Tests added for enable flow button states and interactions.
  • External Wallet/Priority Token:
    • useGetCardExternalWalletDetails: factors allowance-state calc; maps totals safely.
    • useGetPriorityCardToken: minor robustness (nullish coalescing, warning flow); more tests.
  • SDK (CardSDK.ts):
    • Improves error logging/handling across wallet details and provisioning; minor code cleanup.
  • Types:
    • UserResponse adds countryOfNationality.

Written by Cursor Bugbot for commit 1e1b50b. This will update automatically on new commits. Configure here.

a2bee21

… issues (#22221)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

This PR addresses several maintainability issues reported by SonarCloud:
🔗 [View related issues on
SonarCloud](https://sonarcloud.io/project/issues?id=metamask-mobile&pullRequest=22058&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)

Additionally, it reverts a temporary workaround previously added for
Android to prevent a crash occurring when users navigated through the
KYC WebView.
The root cause of the WebView crash has been resolved in a separate PR,
making the temporary fix unnecessary.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: Reverted temporary workaround for KYC WebView crash
(issue resolved in upstream fix).

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Refactors Card features: rewrites asset selection and balance logic,
unifies KYC verification navigation to WebView, tightens onboarding
routing, improves SDK/logging, and adds extensive tests.
> 
> - **Card Home**:
> - Add `enableCardAction` tests covering success/failure/loading paths;
mock `Logger.log`.
>   - Log errors in `enableCardAction` catch.
> - **Asset Selection Bottom Sheet**:
> - Major refactor with helper utilities (network filtering, token
mapping/deduping, CAIP handling, sorting by priority/allowance).
> - Integrate balances via `useAssetBalances`; show allowance state
text; improve list rendering and Solana footer.
> - Preserve existing navigation and priority update, and allow Limited
tokens to update priority directly.
> - **Balances (`useAssetBalances`)**:
> - Extract helpers; improve fiat calculation (market data, Solana
rates, proportional fallback), normalization, and asset building.
> - Update tests with extensive scenarios (enabled/limited/not-enabled,
fallbacks, edge cases).
> - **Onboarding/KYC**:
> - Verify Identity: always navigate to WebView; simplify tests; add
screen view metric.
> - OnboardingNavigator: require `firstName` and `countryOfNationality`
before address; update tests.
>   - Types: add `countryOfNationality` to `UserResponse`.
> - **SDK**:
> - Improve error logging/handling (external wallet details, provision
card); simplify network-to-CAIP mapping; minor cleanup.
> - **Priority/External Wallet Hooks**:
> - Extract `determineAllowanceState`; use nullish coalescing where
applicable; add tests for warnings and fetching behaviors.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
94c9b08. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner November 6, 2025 18:21
@github-actions

github-actions Bot commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Nov 6, 2025
@sonarqubecloud

sonarqubecloud Bot commented Nov 6, 2025

Copy link
Copy Markdown

@joaoloureirop joaoloureirop merged commit 5e04a23 into release/7.58.1 Nov 6, 2025
79 of 88 checks passed
@joaoloureirop joaoloureirop deleted the runway-cherry-pick-7.58.1-1762453296 branch November 6, 2025 19:05
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 6, 2025
@metamaskbot metamaskbot added the release-7.58.1 Issue or pull request that will be included in release 7.58.1 label Nov 6, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.58.1 on PR, as PR was cherry-picked in branch 7.58.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.58.1 Issue or pull request that will be included in release 7.58.1 size-XL team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants