refactor(card): sonarcloud maintainability issues#22221
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…tor/mm-card-maintainability-issues
klejeune
approved these changes
Nov 6, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
This PR addresses several maintainability issues reported by SonarCloud:
🔗 View related issues on SonarCloud
Additionally, it reverts a temporary workaround previously added for Android to prevent a crash occurring when users navigated through the KYC WebView.
The root cause of the WebView crash has been resolved in a separate PR, making the temporary fix unnecessary.
Changelog
CHANGELOG entry: Reverted temporary workaround for KYC WebView crash (issue resolved in upstream fix).
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Refactors Card features: rewrites asset selection and balance logic, unifies KYC verification navigation to WebView, tightens onboarding routing, improves SDK/logging, and adds extensive tests.
enableCardActiontests covering success/failure/loading paths; mockLogger.log.enableCardActioncatch.useAssetBalances; show allowance state text; improve list rendering and Solana footer.useAssetBalances):firstNameandcountryOfNationalitybefore address; update tests.countryOfNationalitytoUserResponse.determineAllowanceState; use nullish coalescing where applicable; add tests for warnings and fetching behaviors.Written by Cursor Bugbot for commit 94c9b08. This will update automatically on new commits. Configure here.