Skip to content

engine swaps flag#2158

Merged
estebanmino merged 1 commit into
developfrom
engine-swaps-flag
Jan 21, 2021
Merged

engine swaps flag#2158
estebanmino merged 1 commit into
developfrom
engine-swaps-flag

Conversation

@estebanmino

Copy link
Copy Markdown
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

@estebanmino estebanmino requested a review from a team as a code owner January 21, 2021 21:04
@estebanmino estebanmino merged commit 008a163 into develop Jan 21, 2021
@estebanmino estebanmino deleted the engine-swaps-flag branch January 21, 2021 21:13
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
github-merge-queue Bot pushed a commit that referenced this pull request Mar 18, 2025
## **Description**

The purpose of this task is to implement a modal / `BottomSheet` that
prevents the user from adding a 6th (greater than 5) browser tab and
instead displays a message conveying this 5-tab limit.

Related conversation with UX team:
https://consensys.slack.com/archives/C06FXU326RL/p1741828020260919?thread_ts=1741818721.798659&cid=C06FXU326RL

Figma design:
https://www.figma.com/design/FWU0ULFNpybSr2d2CIc2YA/Temporary-solution-for-5-max-tabs?node-id=1-12733&t=zctTv4476zPLxFQi-0

## **Related issues**

Fixes: [#2158](https://github.com/MetaMask/mobile-planning/issues/2158)

## **Manual testing steps**

1. Go to in-app browser screen
2. Open 5 tabs
3. Try opening a 6th, and the pop-up modal should display

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/user-attachments/assets/83c804c1-5780-48a5-891f-2ffd7e5f6801

### **After**


https://github.com/user-attachments/assets/a8c4c925-dcd3-436b-95e3-fc83d4a684b0

## **Pre-merge author checklist**

- [X] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [X] I've completed the PR template to the best of my ability
- [X] I’ve included tests if applicable
- [X] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [X] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants