Skip to content

chore(runway): cherry-pick fix: cp-7.57.0 accounts list not scrollable on android#21184

Merged
juanmigdr merged 1 commit into
release/7.57.0from
runway-cherry-pick-7.57.0-1760519202
Oct 15, 2025
Merged

chore(runway): cherry-pick fix: cp-7.57.0 accounts list not scrollable on android#21184
juanmigdr merged 1 commit into
release/7.57.0from
runway-cherry-pick-7.57.0-1760519202

Conversation

@runway-github

@runway-github runway-github Bot commented Oct 15, 2025

Copy link
Copy Markdown
Contributor

Description

Accounts list is not scrollable in android, I have reverted some changes

Changelog

CHANGELOG entry:

Related issues

Fixes: #21181

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Switches FlashList to use react-native-gesture-handler ScrollView for scrolling, restoring list scroll on Android.

  • MultichainAccountSelectorList (MultichainAccountSelectorList.tsx):
    • Use react-native-gesture-handler's ScrollView as the FlashList scroll component via renderScrollComponent.
    • Add ScrollViewProps import and pass typed ScrollView to FlashList.

Written by Cursor Bugbot for commit b73d26a. This will update automatically on new commits. Configure here.

27cf85f

…e on android (#21180)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Accounts list is not scrollable in android, I have reverted some changes
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:

## **Related issues**

Fixes: #21181

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Route FlashList scrolling through `react-native-gesture-handler`
`ScrollView` to fix Android scrolling in the Multichain account selector
list.
> 
> - **Multichain Account Selector List
(`app/component-library/components-temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.tsx`)**:
> - Use `react-native-gesture-handler`'s `ScrollView` via FlashList
`renderScrollComponent` to restore vertical scrolling on Android.
>   - Update imports to include `ScrollView` and `ScrollViewProps`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
11759c1. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner October 15, 2025 09:06
@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Oct 15, 2025
@juanmigdr juanmigdr enabled auto-merge October 15, 2025 09:20
@sonarqubecloud

Copy link
Copy Markdown

@juanmigdr juanmigdr merged commit 6af0a4d into release/7.57.0 Oct 15, 2025
157 of 163 checks passed
@juanmigdr juanmigdr deleted the runway-cherry-pick-7.57.0-1760519202 branch October 15, 2025 09:49
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 15, 2025
@metamaskbot metamaskbot added the release-7.57.0 Issue or pull request that will be included in release 7.57.0 label Oct 15, 2025
@metamaskbot

Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-7.57.0 on PR, as PR was cherry-picked in branch 7.57.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.57.0 Issue or pull request that will be included in release 7.57.0 size-XS team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants