fix: cp-7.57.0 accounts list not scrollable on android#21180
Merged
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This reverts commit 30a6951.
bergarces
approved these changes
Oct 15, 2025
|
ccharly
approved these changes
Oct 15, 2025
ccharly
left a comment
Contributor
There was a problem hiding this comment.
LGTM (not tested though, but I recall testing the account-list before this ScrollView got removed, so we're good).
Collaborator
|
Missing release label release-7.57.0 on PR. Adding release label release-7.57.0 on PR and removing other release labels(release-7.58.0), as PR was cherry-picked in branch 7.57.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Accounts list is not scrollable in android, I have reverted some changes
Changelog
CHANGELOG entry:
Related issues
Fixes: #21181
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
Note
Route FlashList scrolling through
react-native-gesture-handlerScrollViewto fix Android scrolling in the Multichain account selector list.app/component-library/components-temp/MultichainAccounts/MultichainAccountSelectorList/MultichainAccountSelectorList.tsx):react-native-gesture-handler'sScrollViewvia FlashListrenderScrollComponentto restore vertical scrolling on Android.ScrollViewandScrollViewProps.Written by Cursor Bugbot for commit 11759c1. This will update automatically on new commits. Configure here.