Skip to content

bugfix/token tx ui amount parsing#2104

Merged
estebanmino merged 5 commits intodevelopfrom
bugfix/token-tx-amo
Jan 26, 2021
Merged

bugfix/token tx ui amount parsing#2104
estebanmino merged 5 commits intodevelopfrom
bugfix/token-tx-amo

Conversation

@estebanmino
Copy link
Copy Markdown
Contributor

@estebanmino estebanmino commented Jan 8, 2021

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #1914

@estebanmino estebanmino requested a review from a team as a code owner January 8, 2021 15:35
@estebanmino estebanmino changed the title bugfix/token tx amount parsing bugfix/token tx ui amount parsing Jan 8, 2021
@ibrahimtaveras00 ibrahimtaveras00 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 21, 2021
@ibrahimtaveras00 ibrahimtaveras00 mentioned this pull request Jan 21, 2021
Merged
3 tasks
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jan 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 1 from #1914 is fixed, however issue 2 still remains

image

Here I am requesting 1003 HOT and when I end up on the confirm view, I see < 0.00001 HOT instead

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 21, 2021
@estebanmino estebanmino added needs-qa Any New Features that needs a full manual QA prior to being added to a release. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jan 22, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good, QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 25, 2021
@estebanmino estebanmino merged commit 2965bfd into develop Jan 26, 2021
@estebanmino estebanmino deleted the bugfix/token-tx-amo branch January 26, 2021 20:53
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/token tx ui amount parsing (#2104)
48178d7 
* bugfix/token-tx-amount-parsing

* log

* parsingerror
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@rickycodes rickycodes rickycodes approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

QA Passed QA testing has been completed and passed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect values on txn details and payment request deeplink

3 participants

@estebanmino @rickycodes @ibrahimtaveras00