chore: Make Asset sort e2e test more robust cp-7.53.0 by owencraston · Pull Request #18046 · MetaMask/metamask-mobile

owencraston · 2025-08-06T17:32:49Z

Description

This PR unblocks this pr
With FlashList v2, the list tree is not re rendered and instead recycled so we cannot rely on the label to check the order of the list.
to address this, we reload the app so that we can see the new tree label and test the ordering.

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

Feature: my feature name
  Scenario: user [verb for user action]
    Given [describe expected initial app state] 
    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-08-06T17:33:01Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

github-actions · 2025-08-06T17:33:30Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 33cb074
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/63240407-69a3-445c-a828-3ded39e8a751

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

christopherferreira9

lgtm will investigate separately how we can properly assert without relaunching the app.

codecov-commenter · 2025-08-06T17:48:56Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.54%. Comparing base (4bb4d0f) to head (33cb074).
⚠️ Report is 24 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #18046      +/-   ##
==========================================
+ Coverage   74.38%   74.54%   +0.15%     
==========================================
  Files        2985     3019      +34     
  Lines       67286    67943     +657     
  Branches    11289    11449     +160     
==========================================
+ Hits        50051    50645     +594     
- Misses      14006    14013       +7     
- Partials     3229     3285      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-08-06T19:24:27Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: e7e2ceb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5ae550bb-cd28-4567-b327-93c9cb8a31fd

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-08-06T20:10:14Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: eacb2ee
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/af5a8ee5-9036-4ba1-a7e9-e19898ba9572

Note

You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

github-actions · 2025-08-06T21:18:02Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1f93798
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3e823995-f287-45d9-b929-b61cef764524

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-08-06T21:32:25Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

cursor

Bug: Token Sorting Tests Missing Restart Logic

The should sort tokens by fiat amount test is missing the app restart logic and .withMetaMetricsOptIn() fixture configuration that were applied to the should sort tokens alphabetically test. This restart is a workaround for FlashList v2's UI not re-rendering after sort changes. Both tests are affected by this FlashList v2 issue, leading to potential failures or unreliable results for the unfixed test.

e2e/specs/assets/multichain/asset-sort.spec.ts#L93-L125

https://github.com/MetaMask/metamask-mobile/blob/1f93798b068ae5506b6b98e2c26bc245782ed193/e2e/specs/assets/multichain/asset-sort.spec.ts#L93-L125

e2e/specs/assets/multichain/asset-sort.spec.ts#L57-L87

metamask-mobile/e2e/specs/assets/multichain/asset-sort.spec.ts

Lines 57 to 87 in 1f93798

    
           it('should sort tokens alphabetically', async () => { 
        
             await withFixtures( 
        
               { 
        
                 fixture: new FixtureBuilder() 
        
                   .withNetworkController(CustomNetworks.Tenderly.Mainnet) 
        
                   .withTokens([AAVE_TENDERLY_MAINNET_DETAILS]) 
        
                   .withMetaMetricsOptIn() 
        
                   .build(), 
        
                 restartDevice: true, 
        
               }, 
        
               async () => { 
        
                 await loginToApp(); 
        
                 await WalletView.tapSortBy(); 
        
                 await SortModal.tapSortAlphabetically(); 
        
                 // Relaunching the app since the tree is not re-rendered with FlashList v2. 
        
                 await device.terminateApp(); 
        
                 await TestHelpers.launchApp({ 
        
                   launchArgs: { fixtureServerPort: `${getFixturesServerPort()}` }, 
        
                 }); 
        
                 await loginToApp(); 
        
                 const tokens = 
        
                   (await WalletView.getTokensInWallet()) as IndexableNativeElement; 
        
                 const tokensAttributes = await tokens.getAttributes(); 
        
                 const label = (tokensAttributes as { label: string }).label; 
        
                 // Ensure `label` contains "Aave" followed (somewhere) by "Ethereum". 
        
                 const textOrderRegex = new RegExp('Aave([\\s\\S]*?)Ethereum', 'i'); 
        
                 const isMatch = label.match(textOrderRegex); 
        
                 if (!isMatch) {

cortisiko

🌮 🌮 🌮

relaunch app after sort

33cb074

metamaskbot added the team-accounts-framework Accounts team label Aug 6, 2025

owencraston added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E and removed team-accounts-framework Accounts team labels Aug 6, 2025

owencraston marked this pull request as ready for review August 6, 2025 17:34

christopherferreira9 previously approved these changes Aug 6, 2025

View reviewed changes

This comment was marked as outdated.

Sign in to view

opt in to meta metrics

e7e2ceb

owencraston dismissed christopherferreira9’s stale review via e7e2ceb August 6, 2025 19:23

owencraston added Run Smoke E2E and removed Run Smoke E2E labels Aug 6, 2025

This comment was marked as outdated.

Sign in to view

pass fixture as argument

eacb2ee

owencraston added Run Smoke E2E and removed Run Smoke E2E labels Aug 6, 2025

owencraston changed the title ~~chore: Make Asset sort e2e test more robust~~ chore: Make Asset sort e2e test more robust cp-7.53.0 Aug 6, 2025

try terminating the app

1f93798

owencraston added Run Smoke E2E and removed Run Smoke E2E labels Aug 6, 2025

This comment was marked as outdated.

Sign in to view

cursor Bot reviewed Aug 6, 2025

View reviewed changes

metamaskbot added the bitrise-result-ready label Aug 6, 2025

github-actions Bot removed the bitrise-result-ready label Aug 6, 2025

cortisiko approved these changes Aug 6, 2025

View reviewed changes

owencraston added this pull request to the merge queue Aug 6, 2025

Merged via the queue into main with commit c6c099f Aug 6, 2025
54 of 60 checks passed

owencraston deleted the chore/make-asset-sort-e2e-more-robust branch August 6, 2025 22:11

github-actions Bot locked and limited conversation to collaborators Aug 6, 2025

metamaskbot added the release-7.54.0 Issue or pull request that will be included in release 7.54.0 label Aug 6, 2025


	it('should sort tokens alphabetically', async () => {
	await withFixtures(
	{
	fixture: new FixtureBuilder()
	.withNetworkController(CustomNetworks.Tenderly.Mainnet)
	.withTokens([AAVE_TENDERLY_MAINNET_DETAILS])
	.withMetaMetricsOptIn()
	.build(),
	restartDevice: true,
	},
	async () => {
	await loginToApp();
	await WalletView.tapSortBy();
	await SortModal.tapSortAlphabetically();
	// Relaunching the app since the tree is not re-rendered with FlashList v2.
	await device.terminateApp();
	await TestHelpers.launchApp({
	launchArgs: { fixtureServerPort: `${getFixturesServerPort()}` },
	});
	await loginToApp();

	const tokens =
	(await WalletView.getTokensInWallet()) as IndexableNativeElement;
	const tokensAttributes = await tokens.getAttributes();
	const label = (tokensAttributes as { label: string }).label;

	// Ensure `label` contains "Aave" followed (somewhere) by "Ethereum".
	const textOrderRegex = new RegExp('Aave([\\s\\S]*?)Ethereum', 'i');
	const isMatch = label.match(textOrderRegex);
	if (!isMatch) {

Uh oh!

Conversation

owencraston commented Aug 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Aug 6, 2025

Uh oh!

github-actions Bot commented Aug 6, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

christopherferreira9 left a comment

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

codecov-commenter commented Aug 6, 2025

Codecov Report

Uh oh!

github-actions Bot commented Aug 6, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

github-actions Bot commented Aug 6, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

github-actions Bot commented Aug 6, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

sonarqubecloud Bot commented Aug 6, 2025

Quality Gate passed

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Token Sorting Tests Missing Restart Logic

Uh oh!

cortisiko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

owencraston commented Aug 6, 2025 •

edited

Loading

github-actions Bot commented Aug 6, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Aug 6, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Aug 6, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Aug 6, 2025 •

edited by metamaskbot

Loading