Description

1. What is the reason for the change?

• Performance regressions was found during release testing for 7.53.0
• I believe the root cause of this issue is the following...
  • The initial state of the accounts controller is an empty array[]
  • FlashList uses the size of the list combined with the estimatedItemSize prop to draw the list
  • Since 7.51 and 7.53, we introduced multi chain accounts state 1 which changes how the accounts list is rendered. The size of elements is more dynamic (since now we render wallet name, account cell and footers). This combined with the fact that the initial list size starts at 0 was causing issues for the native android RecyclerListView.
  • This warning was logged in the console while testing:
  • WARN FlashList's rendered size is not usable. Either the height or width is too small (<2px). Please make sure that the parent view of the list has a valid size. FlashList will match the size of the parent.1
    • There are several issues online with this warning.
• Why update to FlashList v2 instead of fixing the root cause of the issue?
  • Potential solution 1: Give the list a fixed height
    • This is not possible since the list lives in a bottom drawer popup that has a dynamic height
  • Potential Solution 2: Stop the useAccounts hook from returning an empty array as its initial state.
    • This is a much more difficult fix since that hook combines logic from over 7 selectors.
    • hooks are expected to have state updates and thus handling the dynamic size of the data is a normal react construct. If anything it was a bug in FlashList.

2. What is the improvement/solution?

• Update to FlashList v2 for the following reasons:
  • FlashList v2 handles the dynamic height and list size values without issues
  • Easier to use API (no more need for estimatedSize prop)
  • No more fixed height requirement
  • Fixes the scroll to selected account issue that was present since we migrated to FlashList v1

Resources

• Migrating from FlashList v1 to v2
• FlashList v2: A Ground-Up Rewrite for React Native's New Architecture
• What's new in v2

Changelog

CHANGELOG entry:

Related issues

Fixes: #17541

Manual testing steps

1. Import an SRP with many accounts or create many accounts within your existing wallet
2. open the account list
3. the list should open within a reasonable amount of time and not require a touch event to complete the rendering cycle
4. the list should scroll to the currently selected account

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.