Skip to content

fix: remaining time format cp-7.53.0#17801

Merged
chaitanyapotti merged 6 commits into
mainfrom
fix/remainingTime
Aug 6, 2025
Merged

fix: remaining time format cp-7.53.0#17801
chaitanyapotti merged 6 commits into
mainfrom
fix/remainingTime

Conversation

@ieow

@ieow ieow commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fix remaining Time format to match extension
Fix the counter that stop when app put to background

Changelog

CHANGELOG entry:

Related issues

Fixes:
#17653
#17798

Manual testing steps

  1. Go with seedless rehydrate flow
  2. at unlock screen key in wrong password for > 5 x
  3. too many attempts error should appear, the format should match extension
  4. Put MM to the background for a while
  5. Bring MM back to foreground and make sure the timer did not stop counting when it is on background

Screenshots/Recordings

Before

After

Screen.Recording.2025-08-01.at.2.57.44.PM.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ieow ieow requested a review from a team as a code owner August 1, 2025 07:00
@github-actions

github-actions Bot commented Aug 1, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-onboarding Onboarding team label Aug 1, 2025
@ieow ieow added area-onboarding Run Smoke E2E needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 1, 2025
@ieow ieow self-assigned this Aug 1, 2025
@github-actions

github-actions Bot commented Aug 1, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 8a5e68b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/f16969ca-bd2a-472b-a983-143df89d0946

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

cursor[bot]

This comment was marked as outdated.

Sign in to view

@github-actions

github-actions Bot commented Aug 5, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 58e1364
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fe9a45d6-637a-4c74-b672-54ec0a9cab84

Note

  • You can rerun any failed steps by opening the Bitrise build, tapping Rebuild on the upper right then Rebuild unsuccessful Workflows
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@ieow ieow removed the Run Smoke E2E label Aug 6, 2025
@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: d989e5b
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/05c8a011-b91b-4501-b31b-a8088f104d5d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@ieow ieow changed the title fix: remaining time format fix: remaining time format cp-7.53.0 Aug 6, 2025
@LeVinhGithub

LeVinhGithub commented Aug 6, 2025

Copy link
Copy Markdown
Contributor

lgtm

@LeVinhGithub LeVinhGithub added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Aug 6, 2025
This was linked to issues Aug 6, 2025
[Bug]: Should update the time format for validation timer as extension #17653
Closed
[Bug]: The timer did not count when the app is put in background #17798
Closed
@chaitanyapotti chaitanyapotti added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit c95e0b4 Aug 6, 2025
70 of 76 checks passed
@chaitanyapotti chaitanyapotti deleted the fix/remainingTime branch August 6, 2025 09:24
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees

@ieow ieow

Labels

area-onboarding QA Passed QA testing has been completed and passed release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-onboarding Onboarding team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: The timer did not count when the app is put in background [Bug]: Should update the time format for validation timer as extension

5 participants

@ieow @LeVinhGithub @chaitanyapotti @metamaskbot @tommasini