Skip to content

chore: Send code refactoring#17729

Merged
jpuri merged 119 commits into
mainfrom
feedbacks_17453
Aug 6, 2025
Merged

chore: Send code refactoring#17729
jpuri merged 119 commits into
mainfrom
feedbacks_17453

Conversation

@jpuri

@jpuri jpuri commented Jul 30, 2025

Copy link
Copy Markdown
Contributor

Description

PR addresses review feedbacks on PR: #17453

Changelog

CHANGELOG entry:

Related issues

Fixes:

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

jpuri added 30 commits July 18, 2025 22:18
@jpuri
Adding a very basic send page for new send implementation.
5f11618
@jpuri
update
b4f17b2
@jpuri
update
038ee79
@jpuri
Merge branch 'main' into adding_send_page
dc1cc8c
@jpuri
Pass the asset to send page using routing
0196338
@jpuri
update
000501a
@jpuri
update
d699f93
@jpuri
Merge branch 'adding_send_page' into send_asset
8d24f98
@jpuri
update
2c8010c
@jpuri
Merge branch 'send_asset' of https://github.com/MetaMask/metamask-mobile
9869665 
 into send_asset
@jpuri
update
da81161
@jpuri
update
1f7136e
@jpuri
update
4137aa0
@jpuri
update
02ee52f
@jpuri
update
ea4ec65
@jpuri
update
0cc7ac6
@jpuri
update
88cbdef
@jpuri
update
c93b80d
@jpuri
update
7a685c6
@jpuri
update
dcb51c9
@jpuri
update
f478174
@jpuri
Add support to submit evm transaction
e4adafc
@jpuri
Adding context to send pages
f8b93bb
@jpuri
update
61d8bed
@jpuri
update
dba45f7
@jpuri
Merge branch 'main' into adding_send_page
9601281
@jpuri
Merge branch 'adding_send_page' into send_asset
8d814d0
@jpuri
update
6c5633d
@jpuri
Merge branch 'send_asset' into send_context
aae2e7d
@jpuri
update
b215d73
OGPoyraz
OGPoyraz previously approved these changes Aug 1, 2025
View reviewed changes
Comment thread app/components/Views/confirmations/components/send/amount/amount.tsx
Base automatically changed from fiat_conversion to main August 6, 2025 04:44
@jpuri jpuri dismissed OGPoyraz’s stale review August 6, 2025 04:44

The base branch was changed.

@jpuri jpuri requested a review from OGPoyraz August 6, 2025 04:53
@jpuri jpuri enabled auto-merge August 6, 2025 04:54
@github-actions

github-actions Bot commented Aug 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 6372381
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d5f0e8b6-c2a9-4680-a4de-1bfc8f4dfa06

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
89.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jpuri jpuri added this pull request to the merge queue Aug 6, 2025
Merged via the queue into main with commit ade27db Aug 6, 2025
54 of 56 checks passed
@jpuri jpuri deleted the feedbacks_17453 branch August 6, 2025 06:24
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 6, 2025
@metamaskbot metamaskbot added the release-7.55.0 Issue or pull request that will be included in release 7.55.0 label Aug 6, 2025
@tommasini tommasini added release-7.54.0 Issue or pull request that will be included in release 7.54.0 and removed release-7.55.0 Issue or pull request that will be included in release 7.55.0 labels Aug 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.54.0 Issue or pull request that will be included in release 7.54.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jpuri @OGPoyraz @metamaskbot @tommasini