feat: adding context to send pages by jpuri · Pull Request #17453 · MetaMask/metamask-mobile

jpuri · 2025-07-22T14:42:27Z

Description

The PR add:

A shared contest for send pages
Creating evm transaction and reviewing on send page

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5411
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5426

Manual testing steps

Enable new send page locally
Submit an native asset send and check new flow

Screenshots/Recordings

Screen.Recording.2025-07-23.at.11.05.17.AM.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

into send_asset

github-actions · 2025-07-22T14:42:40Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Bug: Transaction Preparation Fails with Undefined Address

The from?.address as string type assertion can mask a potential undefined value for transactionParams.from if selectSelectedInternalAccount returns undefined, which could lead to runtime errors during transaction preparation or processing. Additionally, a commented-out hardcoded Ethereum address (// to: '0x089595380921f555d52AB6f5a49defdAaB23B444',) was accidentally committed, likely as debugging/test code, and should be removed.

app/components/Views/confirmations/context/send-context/send-context.tsx#L76-L82

metamask-mobile/app/components/Views/confirmations/context/send-context/send-context.tsx

Lines 76 to 82 in 86620da

    
           const from = useSelector(selectSelectedInternalAccount); 
        
           const [transactionParams, setTransactionParams] = useState<TransactionParams>( 
        
             { 
        
               from: from?.address as string, 
        
               // to: '0x089595380921f555d52AB6f5a49defdAaB23B444', 
        
             }, 
        
           );

Fix in Cursor • Fix in Web

Bug: Test Fails: Missing Context Provider

The new tests for Amount and To components render them directly without wrapping them in SendContextProvider. Both components use the useSendContext() hook, which requires this provider, causing the tests to fail at runtime due to the missing context.

app/components/Views/confirmations/components/send/to/to.test.tsx#L7-L11

metamask-mobile/app/components/Views/confirmations/components/send/to/to.test.tsx

Lines 7 to 11 in 86620da

    
           it('renders correctly', async () => { 
        
             const { getByText } = render(<To />); 
        
             expect(getByText('To:')).toBeTruthy(); 
        
           });

app/components/Views/confirmations/components/send/amount/amount.test.tsx#L7-L11

metamask-mobile/app/components/Views/confirmations/components/send/amount/amount.test.tsx

Lines 7 to 11 in 86620da

    
           it('renders correctly', async () => { 
        
             const { getByText } = render(<Amount />); 
        
             expect(getByText('Value:')).toBeTruthy(); 
        
           });

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

github-actions · 2025-07-24T12:46:14Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: db47d29
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/3b55ae64-1b1b-463f-be5f-dbc5707a078f

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-07-24T12:47:55Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jpuri added 23 commits July 18, 2025 22:18

Adding a very basic send page for new send implementation.

5f11618

update

b4f17b2

update

038ee79

Merge branch 'main' into adding_send_page

dc1cc8c

Pass the asset to send page using routing

0196338

update

000501a

update

d699f93

Merge branch 'adding_send_page' into send_asset

8d24f98

update

2c8010c

Merge branch 'send_asset' of https://github.com/MetaMask/metamask-mobile

9869665

into send_asset

update

da81161

update

1f7136e

update

4137aa0

update

02ee52f

update

ea4ec65

update

0cc7ac6

update

88cbdef

update

c93b80d

update

7a685c6

update

dcb51c9

update

f478174

Add support to submit evm transaction

e4adafc

Adding context to send pages

f8b93bb

metamaskbot added the team-confirmations Push issues to confirmations team label Jul 22, 2025

jpuri added 5 commits July 22, 2025 20:39

update

61d8bed

update

dba45f7

Merge branch 'main' into adding_send_page

9601281

Merge branch 'adding_send_page' into send_asset

8d814d0

update

6c5633d

jpuri added 3 commits July 23, 2025 19:34

update

3ab2684

Merge branch 'main' into send_asset

7861294

update

f78f371

This comment was marked as outdated.

Sign in to view

jpuri added 2 commits July 23, 2025 20:04

Merge branch 'main' into send_asset

deebb38

Merge branch 'send_asset' into send_context

86620da

cursor Bot reviewed Jul 23, 2025

View reviewed changes

Base automatically changed from send_asset to main July 24, 2025 11:32

jpuri requested a review from a team as a code owner July 24, 2025 11:32

merge

3a71faa

cursor Bot reviewed Jul 24, 2025

View reviewed changes

Comment thread app/components/Views/confirmations/context/send-context/send-context.tsx

update

db47d29

jpuri enabled auto-merge July 24, 2025 12:33

cursor Bot reviewed Jul 24, 2025

View reviewed changes

Comment thread app/components/Views/confirmations/context/send-context/send-context.tsx

jpuri added the Run Smoke E2E label Jul 24, 2025

metamaskbot added the bitrise-result-ready label Jul 24, 2025

github-actions Bot removed the bitrise-result-ready label Jul 24, 2025

matthewwalsh0 requested changes Jul 29, 2025

View reviewed changes

jpuri requested a review from matthewwalsh0 July 29, 2025 15:17

jpuri mentioned this pull request Jul 30, 2025

chore: Send code refactoring #17729

Merged

7 tasks

matthewwalsh0 approved these changes Jul 30, 2025

View reviewed changes

vinistevam approved these changes Jul 30, 2025

View reviewed changes

jpuri added this pull request to the merge queue Jul 30, 2025

Merged via the queue into main with commit 2c3a464 Jul 30, 2025
52 of 54 checks passed

jpuri deleted the send_context branch July 30, 2025 14:32

github-actions Bot locked and limited conversation to collaborators Jul 30, 2025

metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: adding context to send pages#17453

feat: adding context to send pages#17453
jpuri merged 57 commits into
mainfrom
send_context

jpuri commented Jul 22, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 22, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud Bot commented Jul 24, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	const from = useSelector(selectSelectedInternalAccount);
	const [transactionParams, setTransactionParams] = useState<TransactionParams>(
	{
	from: from?.address as string,
	// to: '0x089595380921f555d52AB6f5a49defdAaB23B444',
	},
	);

	it('renders correctly', async () => {
	const { getByText } = render(<To />);

	expect(getByText('To:')).toBeTruthy();
	});

	it('renders correctly', async () => {
	const { getByText } = render(<Amount />);

	expect(getByText('Value:')).toBeTruthy();
	});

Uh oh!

Conversation

jpuri commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jul 22, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Transaction Preparation Fails with Undefined Address

Bug: Test Fails: Missing Context Provider

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 24, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud Bot commented Jul 24, 2025

Quality Gate passed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jpuri commented Jul 22, 2025 •

edited

Loading

github-actions Bot commented Jul 24, 2025 •

edited by metamaskbot

Loading