Skip to content

feat: Adding a very basic send page for new send implementation.#17384

Merged
jpuri merged 5 commits into
mainfrom
adding_send_page
Jul 23, 2025
Merged

feat: Adding a very basic send page for new send implementation.#17384
jpuri merged 5 commits into
mainfrom
adding_send_page

Conversation

@jpuri

@jpuri jpuri commented Jul 18, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adding a very basic send page hidden behind env variable.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5398

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented Jul 18, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-confirmations Push issues to confirmations team label Jul 18, 2025
@codecov-commenter

codecov-commenter commented Jul 21, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 73.55%. Comparing base (5184987) to head (dc1cc8c).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...p/components/Views/WalletActions/WalletActions.tsx 0.00% 2 Missing and 1 partial ⚠️
app/components/Nav/Main/MainNavigator.js 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17384      +/-   ##
==========================================
- Coverage   73.57%   73.55%   -0.02%     
==========================================
  Files        2845     2846       +1     
  Lines       63338    63391      +53     
  Branches    10328    10350      +22     
==========================================
+ Hits        46598    46627      +29     
- Misses      13741    13751      +10     
- Partials     2999     3013      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jpuri jpuri added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jul 21, 2025
@jpuri jpuri marked this pull request as ready for review July 21, 2025 09:25
@jpuri jpuri requested a review from a team as a code owner July 21, 2025 09:25
@github-actions

github-actions Bot commented Jul 21, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: dc1cc8c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fc667f50-adf6-4362-a57a-f71077c7d309

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@jpuri jpuri changed the title Adding a very basic send page for new send implementation. feat: Adding a very basic send page for new send implementation. Jul 21, 2025
cursor[bot]
cursor Bot reviewed Jul 22, 2025
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Redesign Flow Overlaps with Legacy Send

When MM_SEND_REDESIGNS_ENABLED is true, the function navigates to the new send page but lacks a return statement. This causes the legacy send flow logic, including sendNonEvmAsset(), to execute concurrently, resulting in multiple navigation actions and unexpected behavior.

app/components/Views/WalletActions/WalletActions.tsx#L277-L283

metamask-mobile/app/components/Views/WalletActions/WalletActions.tsx

Lines 277 to 283 in 9601281

if (process.env.MM_SEND_REDESIGNS_ENABLED === 'true') {
closeBottomSheetAndNavigate(() => {
navigate(Routes.SEND.ROOT, {});
});
}

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

@jpuri jpuri added the No QA Needed Apply this label when your PR does not need any QA effort. label Jul 22, 2025
@sonarqubecloud

sonarqubecloud Bot commented Jul 22, 2025

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
38.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@jpuri jpuri enabled auto-merge July 23, 2025 04:39
OGPoyraz
OGPoyraz reviewed Jul 23, 2025
View reviewed changes
Comment thread app/components/Views/confirmations/components/send/index.ts
Comment thread app/components/Nav/Main/MainNavigator.js
@jpuri jpuri requested a review from OGPoyraz July 23, 2025 09:39
matthewwalsh0
matthewwalsh0 approved these changes Jul 23, 2025
View reviewed changes
Comment thread app/components/Views/WalletActions/WalletActions.tsx
Comment thread app/components/Views/confirmations/components/send/send.tsx
Comment thread .js.env.example
Comment thread app/components/Views/confirmations/components/send/index.ts
Comment thread app/components/Nav/Main/MainNavigator.js
@jpuri

jpuri commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

@matthewwalsh0 : I will address the smaller feedbacks in the next PR

@jpuri jpuri added this pull request to the merge queue Jul 23, 2025
Merged via the queue into main with commit 3f11793 Jul 23, 2025
47 of 49 checks passed
@jpuri jpuri deleted the adding_send_page branch July 23, 2025 13:09
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2025
@metamaskbot metamaskbot added the release-7.53.0 Issue or pull request that will be included in release 7.53.0 label Jul 23, 2025
@jpuri

jpuri commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

Feedbacks addressed here #17415

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

@cursor cursor[bot] cursor[bot] left review comments

@OGPoyraz OGPoyraz OGPoyraz approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.53.0 Issue or pull request that will be included in release 7.53.0 skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpuri @codecov-commenter @OGPoyraz @matthewwalsh0 @metamaskbot