feat: Pass the asset to send page using routing by jpuri · Pull Request #17415 · MetaMask/metamask-mobile

jpuri · 2025-07-21T12:21:24Z

Description

Passing the asset information to the send page if available.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://github.com/MetaMask/MetaMask-planning/issues/5407

Manual testing steps

NA

Screenshots/Recordings

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-07-21T12:21:32Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

into send_asset

github-actions · 2025-07-23T14:35:37Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: deebb38
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/29cdf8b8-2e3f-43de-a83d-cd4ae2ac8fe2

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

cursor

Bug: Send Screen Asset Parameter Mismatch

In CollectibleView, when navigating to the Send screen (for the new redesign flow), the collectible params object is passed directly as navigation parameters. This is incorrect, as the Send component expects the asset data to be nested under an asset key (e.g., { asset: params }). This inconsistent parameter structure differs from other components that correctly wrap their asset data.

app/components/Views/CollectibleView/index.js#L86-L94

metamask-mobile/app/components/Views/CollectibleView/index.js

Lines 86 to 94 in deebb38

    
           this.props.newAssetTransaction(params); 
        
           if (isSendRedesignEnabled()) { 
        
             this.props.navigation.navigate(Routes.SEND.DEFAULT, { 
        
               screen: Routes.SEND.ROOT, 
        
               params, 
        
             }); 
        
           } else { 
        
             this.props.navigation.navigate('SendFlowView'); 
        
           }

Fix in Cursor • Fix in Web

Bug: Send Flow Fails to Pass Selected Asset

In the redesigned send flow initiated from WalletActions, the selected asset is not dispatched to the global state or passed via navigation parameters. A return statement prevents the asset dispatch logic (present in the legacy flow) from executing. Consequently, the send component lacks the selected asset, unlike other navigation paths (e.g., AssetOverview) or the legacy flow, which correctly provide this data.

app/components/Views/WalletActions/WalletActions.tsx#L299-L307

metamask-mobile/app/components/Views/WalletActions/WalletActions.tsx

Lines 299 to 307 in deebb38

    
           if (isSendRedesignEnabled()) { 
        
             closeBottomSheetAndNavigate(() => { 
        
               navigate(Routes.SEND.DEFAULT, { 
        
                 screen: Routes.SEND.ROOT, 
        
               }); 
        
             }); 
        
             return; 
        
           }

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-23T15:00:32Z

Quality Gate failed

Failed conditions
53.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

jpuri added 5 commits July 18, 2025 22:18

Adding a very basic send page for new send implementation.

5f11618

update

b4f17b2

update

038ee79

Merge branch 'main' into adding_send_page

dc1cc8c

Pass the asset to send page using routing

0196338

jpuri requested a review from a team as a code owner July 21, 2025 12:21

jpuri added the team-confirmations Push issues to confirmations team label Jul 21, 2025

jpuri requested a review from a team as a code owner July 21, 2025 12:21