feat: Add the expo flask pipeline by ixf · Pull Request #15792 · MetaMask/metamask-mobile

ixf · 2025-05-28T12:20:54Z

Description

This creates a Bitrise pipeline for creating flask builds.

Changes made:

build:ios:flask:local and build:android:flask:local is used by Bitrise for generating Flask Expo prebuild in CI
Added Flask development provisioning profile
generateIosBinary selects the correct plist

Related issues

Fixes: #15563

Manual testing steps

Go to bitrise, make a new build from this branch using expo_flask_pipeline
Verify that there are 4 artifacts - main .apk, test .apk, .ipa and .app
Install .apk on Android emulator, verify that the Flask target is installed
Install .ipa and .app on iOS simulator and device, verify that the Flask target is installed
yarn watch and run the app

For reference here's the latest bitrise build of this pipeline:
https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/be69d047-60ea-400d-8a39-4153f0d85f84

Screenshots/Recordings

After

Installing .ipa and .apk

flask-installs.mov

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-05-28T12:21:06Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

ixf · 2025-05-28T15:07:41Z

I have read the CLA Document and I hereby sign the CLA

codecov-commenter · 2025-05-30T16:38:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (f6f4594) to head (c6505c4).
Report is 51 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #15792      +/-   ##
==========================================
+ Coverage   69.58%   69.97%   +0.38%     
==========================================
  Files        2473     2530      +57     
  Lines       53007    54023    +1016     
  Branches     8063     8309     +246     
==========================================
+ Hits        36886    37800     +914     
- Misses      13752    13784      +32     
- Partials     2369     2439      +70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Cal-L

left a comment

github-actions · 2025-07-09T02:27:44Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: 58d1a04
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/03f07dc8-8917-432b-a8d9-4000ed607ceb

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L

Added comments for context

github-actions · 2025-07-09T02:51:17Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 1f482bb
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4b2ada34-0635-4f5c-8ecb-c204644b71c9

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Cal-L · 2025-07-09T21:52:40Z

E2E passed already, just resolved conflict from main

cursor

Bug: Android Build Script Issues

The scripts/build.sh script introduces two issues in Android builds:

The buildAndroidDevBuild function no longer sources environment variables from .android.env when PRE_RELEASE is true, as the sourcing logic in prebuild_android is now conditional on PRE_RELEASE being false. This can lead to build failures.
Both buildAndroidDevBuild and the newly added buildAndroidFlaskLocal functions are missing the -DtestBuildType=debug parameter when building their respective AndroidTest APKs (assembleProdDebugAndroidTest and assembleFlaskDebugAndroidTest). This omission breaks consistency with other test builds and may cause build or test failures.

scripts/build.sh#L286-L299

metamask-mobile/scripts/build.sh

Lines 286 to 299 in 5ba996b

    
           buildAndroidDevBuild(){ 
        
           	prebuild_android 
        
           	# Generate both APK (for development) and test APK (for E2E testing) 
        
           	cd android && ./gradlew assembleProdDebug assembleProdDebugAndroidTest --build-cache --parallel && cd .. 
        
           } 
        
           # Builds the Flask APK for local development 
        
           buildAndroidFlaskLocal(){ 
        
           	prebuild_android 
        
           	# Generate both APK (for development) and test APK (for E2E testing) 
        
           	cd android && ./gradlew assembleFlaskDebug assembleFlaskDebugAndroidTest --build-cache --parallel && cd ..

Fix in Cursor • Fix in Web

Bug: Build Function Directory Inconsistency

The buildIosFlaskLocal function changes to the ios directory but does not return, which is inconsistent with other build functions and can cause subsequent operations to run from the wrong directory. Additionally, the remapFlaskEnvVariables call was removed from buildIosFlaskRelease to rely on a new global call for Flask modes. This creates an inconsistency where Android Flask release builds may still have a redundant remapFlaskEnvVariables call, leading to it being executed twice for Android but only once for iOS, potentially causing unexpected environment variable behavior.

scripts/build.sh#L460-L471

metamask-mobile/scripts/build.sh

Lines 460 to 471 in 5ba996b

    
           buildIosFlaskLocal() { 
        
           	prebuild_ios 
        
           	# Go to ios directory 
        
           	cd ios 
        
           	# Generate a Flask debug .ipa for local 
        
           	generateIosBinary "MetaMask-Flask" "Debug" 
        
           } 
        
           buildIosFlaskRelease(){ 
        
           	prebuild_ios

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

sonarqubecloud · 2025-07-09T22:05:12Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Cal-L · 2025-07-09T22:11:51Z

All cursor comments are expected. The Expo prebuild configuration is most up-to-date. Other configurations will be updated in follow up PRs

metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 28, 2025

ixf force-pushed the swmansion/feat-expo-flask-prebuilds branch from 2655520 to 6065345 Compare May 30, 2025 15:06

ixf force-pushed the swmansion/feat-expo-flask-prebuilds branch 4 times, most recently from 09c285c to 52c28d6 Compare June 10, 2025 11:45

ixf added 9 commits June 10, 2025 16:01

feat: Add the expo flash pipeline

13628fc

Fix wrong buildtype for ios flask device builds

f0addfb

Set app scheme in buildIosDevBuild based on env

98b5492

Add a flask dev provisioning profile

2d548b9

add Flask build support for Android dev builds

d7fa3c8

Avoid moving AAB when BUNDLE_DIR is unset

5f7b4d8

Update flask development provisioning profile

ee62399

Set manual code signing for flask debug builds

35c4be0

Fix signing options for flask debug builds

6595493

ixf force-pushed the swmansion/feat-expo-flask-prebuilds branch from 52c28d6 to 6595493 Compare June 10, 2025 14:23

Cal-L changed the title ~~feat: Add the expo flash pipeline~~ feat: Add the expo flask pipeline Jun 11, 2025

Cal-L reviewed Jun 12, 2025

View reviewed changes

Comment thread bitrise.yml

Cal-L reviewed Jun 12, 2025

View reviewed changes

Cal-L mentioned this pull request Jun 12, 2025

feat: Add the expo QA pipeline #16264

Merged

7 tasks

Cal-L added 7 commits June 12, 2025 15:54

add android and ios commands for exp build

2d84267

Add android and ios scripts to package.json for exp build

fbb1904

Create experimental feature set for experimental environment

7d43ab4

Check for correct experimental environment

effc5f1

Point to Sentry main-exp environment

6a67d5d

Use QA environment vars for experimental

0eff164

Point feature flag to experimental

86d9914

Cal-L added the Run Smoke E2E label Jul 9, 2025

This comment was marked as outdated.

Sign in to view

Update comment

7daa1a1

This comment was marked as outdated.

Sign in to view

Revert flask device build

1f482bb

Cal-L reviewed Jul 9, 2025

View reviewed changes

Cal-L added Run Smoke E2E and removed Run Smoke E2E labels Jul 9, 2025

metamaskbot added the bitrise-result-ready label Jul 9, 2025

github-actions Bot removed the bitrise-result-ready label Jul 9, 2025

Cal-L enabled auto-merge July 9, 2025 20:59

Merge from main

5ba996b

Cal-L added No E2E Smoke Needed and removed INVALID-PR-TEMPLATE PR's body doesn't match template Run Smoke E2E labels Jul 9, 2025

cursor Bot reviewed Jul 9, 2025

View reviewed changes

weitingsun approved these changes Jul 9, 2025

View reviewed changes

Cal-L added this pull request to the merge queue Jul 9, 2025

github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jul 9, 2025

Merged via the queue into main with commit 8b382ea Jul 9, 2025
56 checks passed

Cal-L deleted the swmansion/feat-expo-flask-prebuilds branch July 9, 2025 23:05

github-actions Bot locked and limited conversation to collaborators Jul 9, 2025

github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 9, 2025

metamaskbot added the release-7.52.0 Issue or pull request that will be included in release 7.52.0 label Jul 9, 2025


	buildAndroidDevBuild(){
	prebuild_android

	# Generate both APK (for development) and test APK (for E2E testing)
	cd android && ./gradlew assembleProdDebug assembleProdDebugAndroidTest --build-cache --parallel && cd ..
	}

	# Builds the Flask APK for local development
	buildAndroidFlaskLocal(){
	prebuild_android

	# Generate both APK (for development) and test APK (for E2E testing)
	cd android && ./gradlew assembleFlaskDebug assembleFlaskDebugAndroidTest --build-cache --parallel && cd ..


	buildIosFlaskLocal() {
	prebuild_ios

	# Go to ios directory
	cd ios
	# Generate a Flask debug .ipa for local
	generateIosBinary "MetaMask-Flask" "Debug"
	}

	buildIosFlaskRelease(){
	prebuild_ios

Uh oh!

Conversation

ixf commented May 28, 2025 • edited by Cal-L Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented May 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ixf commented May 28, 2025

Uh oh!

codecov-commenter commented May 30, 2025

Codecov Report

Uh oh!

Uh oh!

Cal-L left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Jul 9, 2025

Bitrise

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Cal-L left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

Cal-L commented Jul 9, 2025

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Bug: Android Build Script Issues

Bug: Build Function Directory Inconsistency

Uh oh!

sonarqubecloud Bot commented Jul 9, 2025

Quality Gate passed

Uh oh!

Cal-L commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

ixf commented May 28, 2025 •

edited by Cal-L

Loading

github-actions Bot commented May 28, 2025 •

edited

Loading

github-actions Bot commented Jul 9, 2025 •

edited by metamaskbot

Loading