Skip to content

chore(runway): cherry-pick fix: cp-7.47.0 fix endowment:caip25 error when removing dapp permitted chain#15354

Merged
NicolasMassart merged 1 commit into
release/7.47.0from
runway-cherry-pick-7.47.0-1747307973
May 15, 2025
Merged

chore(runway): cherry-pick fix: cp-7.47.0 fix endowment:caip25 error when removing dapp permitted chain#15354
NicolasMassart merged 1 commit into
release/7.47.0from
runway-cherry-pick-7.47.0-1747307973

Conversation

@runway-github

@runway-github runway-github Bot commented May 15, 2025

Copy link
Copy Markdown
Contributor

Description

Having a chain permitted on a dapp, and then removing said network from
wallet throws an error when going back to dapp and trying to switch to
the currently selected network. Original ticket for the issue is
here.

This PR makes sure we properly filter out the deleted network when
updating the permission for the currently selected network/s.

Related issues

Fixes:
#15201

Manual testing steps

  1. Go to any dapp via in app browser
  2. Connect and permit a chain (ex.: Polygon)
  3. Go back to wallet
  4. Change selected chain (ex.: to Ethereum mainnet)
  5. Remove the previously permitted chain from the available networks
    (ex.: remove Polygon)
  6. Go back to dapp and confirm adding the newly selected chain
  7. No exception should show up ✅

Screenshots/Recordings

Before

Screen.Recording.2025-05-15.at.09.36.40.mov

After

Screen.Recording.2025-05-15.at.11.58.59.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. a21b310

…when removing dapp permitted chain (#15352)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Having a chain permitted on a dapp, and then removing said network from
wallet throws an error when going back to dapp and trying to switch to
the currently selected network. Original ticket for the issue is
[here](#15201).

This PR makes sure we properly filter out the deleted network when
updating the permission for the currently selected network/s.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes:
#15201

## **Manual testing steps**

1. Go to any dapp via in app browser
2. Connect and permit a chain (ex.: Polygon)
3. Go back to wallet
4. Change selected chain (ex.: to Ethereum mainnet)
5. Remove the previously permitted chain from the available networks
(ex.: remove Polygon)
6. Go back to dapp and confirm adding the newly selected chain
7. No exception should show up ✅ 

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**


https://github.com/user-attachments/assets/a79b6b35-8690-4e3a-ba74-b8592e4300b8

### **After**


https://github.com/user-attachments/assets/001dd4c8-4c38-4464-91fb-a78058889feb

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label May 15, 2025
@ffmcgee725 ffmcgee725 requested a review from NicolasMassart May 15, 2025 11:30
@sonarqubecloud

Copy link
Copy Markdown

@NicolasMassart NicolasMassart enabled auto-merge (squash) May 15, 2025 12:54
@NicolasMassart NicolasMassart merged commit 201e9b1 into release/7.47.0 May 15, 2025
41 of 43 checks passed
@NicolasMassart NicolasMassart deleted the runway-cherry-pick-7.47.0-1747307973 branch May 15, 2025 12:54
@github-actions github-actions Bot locked and limited conversation to collaborators May 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants