chore(runway): cherry-pick fix: cp-7.47.0 fix endowment:caip25 error when removing dapp permitted chain#15354
Merged
NicolasMassart merged 1 commit intoMay 15, 2025
Conversation
…when removing dapp permitted chain (#15352) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Having a chain permitted on a dapp, and then removing said network from wallet throws an error when going back to dapp and trying to switch to the currently selected network. Original ticket for the issue is [here](#15201). This PR makes sure we properly filter out the deleted network when updating the permission for the currently selected network/s. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** Fixes: #15201 ## **Manual testing steps** 1. Go to any dapp via in app browser 2. Connect and permit a chain (ex.: Polygon) 3. Go back to wallet 4. Change selected chain (ex.: to Ethereum mainnet) 5. Remove the previously permitted chain from the available networks (ex.: remove Polygon) 6. Go back to dapp and confirm adding the newly selected chain 7. No exception should show up ✅ ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** https://github.com/user-attachments/assets/a79b6b35-8690-4e3a-ba74-b8592e4300b8 ### **After** https://github.com/user-attachments/assets/001dd4c8-4c38-4464-91fb-a78058889feb ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
NicolasMassart
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Having a chain permitted on a dapp, and then removing said network from
wallet throws an error when going back to dapp and trying to switch to
the currently selected network. Original ticket for the issue is
here.
This PR makes sure we properly filter out the deleted network when
updating the permission for the currently selected network/s.
Related issues
Fixes:
#15201
Manual testing steps
(ex.: remove Polygon)
Screenshots/Recordings
Before
Screen.Recording.2025-05-15.at.09.36.40.mov
After
Screen.Recording.2025-05-15.at.11.58.59.mov
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots. a21b310