fix: cp-7.47.0 fix endowment:caip25 error when removing dapp permitted chain#15352
Merged
Merged
Conversation
Contributor
|
|
abretonc7s
approved these changes
May 15, 2025
tommasini
approved these changes
May 15, 2025
Member
Author
|
This one pipeline run_trade_swimlane_android_smoke failed, but it's been known for flakyness for some time now so I will push this forward |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Having a chain permitted on a dapp, and then removing said network from wallet throws an error when going back to dapp and trying to switch to the currently selected network. Original ticket for the issue is here.
This PR makes sure we properly filter out the deleted network when updating the permission for the currently selected network/s.
Related issues
Fixes:
#15201
Manual testing steps
Screenshots/Recordings
Before
Screen.Recording.2025-05-15.at.09.36.40.mov
After
Screen.Recording.2025-05-15.at.11.58.59.mov
Pre-merge author checklist
Pre-merge reviewer checklist