Skip to content

chore(runway): cherry-pick chore: cp-7.47.0 upgrade assets-controller v62.0.0#15289

Merged
NicolasMassart merged 3 commits into
release/7.47.0from
runway-cherry-pick-7.47.0-1747137681
May 13, 2025
Merged

chore(runway): cherry-pick chore: cp-7.47.0 upgrade assets-controller v62.0.0#15289
NicolasMassart merged 3 commits into
release/7.47.0from
runway-cherry-pick-7.47.0-1747137681

Conversation

@runway-github

@runway-github runway-github Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

Description

Upgrade assets-controllers to v62

Related issues

Fixes:

Manual testing steps

  1. Import Solana account
  2. Make sure you see balances in crypto and fiat
  3. Create new accounts and switch between accounts, it should show
    balances and prices as expected

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots. 3a09663

@sahar-fehri
chore(runway): cherry-pick chore: cp-7.47.0 upgrade assets-controller…
16e2d5f 
… v62.0.0 (#15261)

## **Description**

Upgrade assets-controllers to v62

## **Related issues**

Fixes:

## **Manual testing steps**

1. Import Solana account
2. Make sure you see balances in crypto and fiat
3. Create new accounts and switch between accounts, it should show
balances and prices as expected


## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@runway-github runway-github Bot requested a review from a team May 13, 2025 12:01
@github-actions

github-actions Bot commented May 13, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label May 13, 2025
@socket-security

socket-security Bot commented May 13, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​controller-utils@​11.7.0 ⏵ 11.8.095 +110075 +196 +5100
Updatednpm/​@​metamask/​assets-controllers@​61.0.0 ⏵ 62.0.091 +110090 +1100 +2100

View full report

@sonarqubecloud

sonarqubecloud Bot commented May 13, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@socket-security

socket-security Bot commented May 13, 2025

Copy link
Copy Markdown

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Action Severity Alert (click for details)
Block Medium
npm/@metamask/controller-utils@11.8.0 has Network access.

Module: globalThis["fetch"]

Location: Package overview

From: package.json → npm/@metamask/controller-utils@11.8.0

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/controller-utils@11.8.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@github-actions

github-actions Bot commented May 13, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: eb6b0c1
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/ed2df126-a334-41bd-9a5d-6f8abe645cd7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@NicolasMassart NicolasMassart merged commit e126d89 into release/7.47.0 May 13, 2025
30 of 33 checks passed
@NicolasMassart NicolasMassart deleted the runway-cherry-pick-7.47.0-1747137681 branch May 13, 2025 14:25
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NicolasMassart NicolasMassart NicolasMassart approved these changes

Assignees

No one assigned

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasMassart @metamaskbot @sahar-fehri