Skip to content

chore: cp-7.47.0 upgrade assets-controller v62.0.0#15261

Merged
sahar-fehri merged 6 commits into
mainfrom
chore/upgrade-assets-controllers-v62.0.0
May 13, 2025
Merged

chore: cp-7.47.0 upgrade assets-controller v62.0.0#15261
sahar-fehri merged 6 commits into
mainfrom
chore/upgrade-assets-controllers-v62.0.0

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented May 9, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Upgrade assets-controllers to v62

Related issues

Fixes:

Manual testing steps

  1. Import Solana account
  2. Make sure you see balances in crypto and fiat
  3. Create new accounts and switch between accounts, it should show balances and prices as expected

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions

github-actions Bot commented May 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented May 9, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​controller-utils@​11.7.0 ⏵ 11.8.094 +110075 +196 +5100
Updatednpm/​@​metamask/​assets-controllers@​61.0.0 ⏵ 62.0.091 +110090 +1100 +2100

View full report

@sahar-fehri sahar-fehri marked this pull request as ready for review May 9, 2025 10:27
@sahar-fehri sahar-fehri requested a review from a team May 9, 2025 10:27
@github-actions

github-actions Bot commented May 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: cbea35a
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/8571fe4e-6f21-4d41-bdd7-0cea4da4a216

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

bergarces
bergarces previously approved these changes May 9, 2025
View reviewed changes
@sahar-fehri sahar-fehri changed the title chore: upgrade assets-controller v62.0.0 chore: cp-7.47.0 upgrade assets-controller v62.0.0 May 9, 2025
Prithpal-Sooriya
Prithpal-Sooriya reviewed May 9, 2025
View reviewed changes
Comment thread patches/@metamask+assets-controllers+62.0.0.patch
@github-actions

github-actions Bot commented May 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 20d536e
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbf9b0e0-bf2e-4e66-a3ca-ca95c3a46d86

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@github-actions

github-actions Bot commented May 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4380ab4
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/a2d9d81b-3214-4f1f-b7b5-d711c1fe7f3f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions

github-actions Bot commented May 12, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: ebeb81c
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b143d533-06d5-438c-8e98-5902d20a2c26

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@socket-security

socket-security Bot commented May 12, 2025 •
edited
Loading

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • npm/@metamask/controller-utils@11.8.0

View full report

@sahar-fehri

sahar-fehri commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore npm/@metamask/controller-utils@11.8.0

@Prithpal-Sooriya

Prithpal-Sooriya commented May 12, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

QA-ed, this fixes the rates issue on Solana.

UPDATE:

@sahar-fehri

sahar-fehri commented May 12, 2025

Copy link
Copy Markdown
Contributor Author

QA-ed, this fixes the rates issue on Solana.

UPDATE:

I think that should be fixed by this MetaMask/metamask-extension#32758

@sahar-fehri sahar-fehri added the No QA Needed Apply this label when your PR does not need any QA effort. label May 12, 2025
@sonarqubecloud

sonarqubecloud Bot commented May 12, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tommasini
tommasini approved these changes May 13, 2025
View reviewed changes

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it would be great to keep the changelog complete at core, because it does't mention that the MultichainAssetsController:accountAssetListUpdated event needs to be added to MultichainTokenBalancesController and MultichainAssetsRatesController like the PR that did that change

@sahar-fehri sahar-fehri added this pull request to the merge queue May 13, 2025
Merged via the queue into main with commit 3a09663 May 13, 2025
43 of 44 checks passed
@sahar-fehri sahar-fehri deleted the chore/upgrade-assets-controllers-v62.0.0 branch May 13, 2025 11:53
@github-actions github-actions Bot locked and limited conversation to collaborators May 13, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 13, 2025
@sahar-fehri sahar-fehri added the area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. label May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

@tommasini tommasini tommasini approved these changes

@bergarces bergarces bergarces left review comments

Assignees

No one assigned

Labels

area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sahar-fehri @Prithpal-Sooriya @bergarces @tommasini @metamaskbot