Skip to content

chore: cp-12.18.0 upgrade solana-wallet-snap to v1.27.0#32758

Merged
aganglada merged 1 commit into
mainfrom
chore/upgrade-solana-wallet-snap-1.27.0
May 9, 2025
Merged

chore: cp-12.18.0 upgrade solana-wallet-snap to v1.27.0#32758
aganglada merged 1 commit into
mainfrom
chore/upgrade-solana-wallet-snap-1.27.0

Conversation

@sahar-fehri

@sahar-fehri sahar-fehri commented May 9, 2025

Copy link
Copy Markdown
Contributor

Description

Upgrade solana-wallet-snap dep to v1.27.0

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@sahar-fehri sahar-fehri marked this pull request as ready for review May 9, 2025 15:20
@github-actions

github-actions Bot commented May 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented May 9, 2025

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​solana-wallet-snap@​1.26.1 ⏵ 1.27.092 -810087 -13100100

View full report

@socket-security

socket-security Bot commented May 9, 2025

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • @metamask/solana-wallet-snap@1.27.0

View full report

@sahar-fehri sahar-fehri requested review from aganglada and zone-live May 9, 2025 15:29
@metamaskbot

Copy link
Copy Markdown
Collaborator
Builds ready [235ccc7]
UI Startup Metrics (1227 ± 76 ms)
PlatformBuildTypePageMetricMean (ms)Min (ms)Max (ms)Std Dev (ms)P 75 (ms)P 95 (ms)
ChromeBrowserifyHomeuiStartup1227109114157612691400
load107495512897211071244
domContentLoaded106794312777211021237
domInteractive16142931625
firstPaint728142126442710861217
backgroundConnect84305820
firstReactRender19155142028
getState1463871929
initialActions001001
loadScripts824713103271858999
setupStore85213912
WebpackHomeuiStartup22751853264016224122487
load17871421224516018962075
domContentLoaded17781417224015818851960
domInteractive171280121446
firstPaint1706538566200311
backgroundConnect3210174214263
firstReactRender17557472111280350
getState3053325921198
initialActions318136
loadScripts17701416223915618811951
setupStore217180252144
FirefoxBrowserifyHomeuiStartup13531166186312613961626
load12081035170712312481451
domContentLoaded12081035170612312471450
domInteractive1003734136110152
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect2213112162057
firstReactRender24195272347
getState9419720817
initialActions001001
loadScripts11891018160712012301436
setupStore64395610
WebpackHomeuiStartup15571370207513416261811
load13281167177411813651553
domContentLoaded13281167177411813651553
domInteractive80361531987126
firstPaintNaNNaNNaNNaNNaNNaN
backgroundConnect22145572439
firstReactRender36295853747
getState135280281031
initialActions102111
loadScripts13091150175811913491537
setupStore14531141919
cc: @HowardBraham
Benchmark value 1075 exceeds gate value 1070 for chrome browserify home mean load
Benchmark value 1067 exceeds gate value 1061 for chrome browserify home mean domContentLoaded
Benchmark value 1401 exceeds gate value 1365 for chrome browserify home p95 uiStartup
Benchmark value 1244 exceeds gate value 1190 for chrome browserify home p95 load
Benchmark value 1237 exceeds gate value 1180 for chrome browserify home p95 domContentLoaded
Benchmark value 1218 exceeds gate value 1180 for chrome browserify home p95 firstPaint
Benchmark value 21 exceeds gate value 18 for chrome browserify home p95 backgroundConnect
Benchmark value 999 exceeds gate value 940 for chrome browserify home p95 loadScripts
Benchmark value 2276 exceeds gate value 2192 for chrome webpack home mean uiStartup
Benchmark value 1787 exceeds gate value 1711 for chrome webpack home mean load
Benchmark value 1779 exceeds gate value 1704 for chrome webpack home mean domContentLoaded
Benchmark value 31 exceeds gate value 29 for chrome webpack home mean getState
Benchmark value 1771 exceeds gate value 1699 for chrome webpack home mean loadScripts
Benchmark value 2487 exceeds gate value 2454 for chrome webpack home p95 uiStartup
Benchmark value 2076 exceeds gate value 2030 for chrome webpack home p95 load
Benchmark value 198 exceeds gate value 195 for chrome webpack home p95 getState
Benchmark value 15 exceeds gate value 13 for firefox webpack home mean setupStore
Sum of mean exceeds: 322ms | Sum of p95 exceeds: 329ms
Sum of all benchmark exceeds: 651ms

Bundle size diffs
  • background: 0 Bytes (0%)
  • ui: 0 Bytes (0%)
  • common: 0 Bytes (0%)

@sahar-fehri sahar-fehri changed the title chore: upgrade solana-wallet-snap to v1.27.0 chore: cp-12.18.0 upgrade solana-wallet-snap to v1.27.0 May 9, 2025
@sahar-fehri

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore-all

@aganglada aganglada enabled auto-merge May 9, 2025 16:53
@aganglada aganglada added this pull request to the merge queue May 9, 2025
@aganglada aganglada removed this pull request from the merge queue due to a manual request May 9, 2025
@dylanbutler1

Copy link
Copy Markdown
Contributor

Approved for cherry picking into 12.18.0.

@aganglada aganglada added this pull request to the merge queue May 9, 2025
Merged via the queue into main with commit 7181f79 May 9, 2025
170 of 172 checks passed
@aganglada aganglada deleted the chore/upgrade-solana-wallet-snap-1.27.0 branch May 9, 2025 17:39
@github-actions github-actions Bot locked and limited conversation to collaborators May 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants