Skip to content

perf: accounts improvements#15194

Merged
ccharly merged 5 commits into
mainfrom
perf/accounts-improvements
May 7, 2025
Merged

perf: accounts improvements#15194
ccharly merged 5 commits into
mainfrom
perf/accounts-improvements

Conversation

@ccharly

@ccharly ccharly commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Caution

Requires this PR to be merged first:

Upgrade controllers to use the new accounts perf improvements, notably:

Related issues

N/A

Manual testing steps

  1. Create a Solana account
  2. It should run faster

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@ccharly ccharly self-assigned this May 6, 2025
@ccharly ccharly added team-accounts-framework Accounts team area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. labels May 6, 2025
@github-actions

github-actions Bot commented May 6, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@ccharly ccharly changed the base branch from main to chore/upgrade-assets-controller-v60 May 6, 2025 20:39
@ccharly ccharly force-pushed the perf/accounts-improvements branch from 147b1df to 74dec30 Compare May 6, 2025 20:41
@socket-security

socket-security Bot commented May 6, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​multichain-transactions-controller@​0.8.0 ⏵ 0.10.090 +110072 +197 +3100
Updatednpm/​@​metamask/​earn-controller@​0.12.0 ⏵ 0.13.084 +31007298 +2100
Updatednpm/​@​metamask/​multichain-network-controller@​0.5.1 ⏵ 0.6.0941007397 +2100
Updatednpm/​@​metamask/​bridge-status-controller@​16.0.0 ⏵ 18.0.083 -510075 +199 +1100
Updatednpm/​@​metamask/​accounts-controller@​27.0.0 ⏵ 28.0.091 +110075 +195 -2100
Updatednpm/​@​metamask/​keyring-controller@​21.0.4 ⏵ 21.0.69210076 +1100 +1100
Updatednpm/​@​metamask/​signature-controller@​27.1.0 ⏵ 28.0.0901007698 +2100
Updatednpm/​@​metamask/​bridge-controller@​20.0.0 ⏵ 21.0.091 -910076 -2499 -1100
Updatednpm/​@​metamask/​user-operation-controller@​33.0.0 ⏵ 34.0.0881007799 +2100
Updatednpm/​@​metamask/​transaction-controller@​54.0.0 ⏵ 55.0.09210079 +1100 +1100
Updatednpm/​@​metamask/​profile-sync-controller@​12.0.0 ⏵ 13.0.09110086100 +2100
Updatednpm/​@​metamask/​notification-services-controller@​6.0.0 ⏵ 7.0.091 +110087 +1100 +1100
Updatednpm/​@​metamask/​assets-controllers@​60.0.0 ⏵ 61.0.091 -11009099 -1100

View full report

Base automatically changed from chore/upgrade-assets-controller-v60 to main May 6, 2025 21:29
@ccharly ccharly force-pushed the perf/accounts-improvements branch from 74dec30 to 4802c1e Compare May 6, 2025 21:30
@ccharly ccharly marked this pull request as ready for review May 6, 2025 21:30
@ccharly ccharly requested a review from a team May 6, 2025 21:30
@github-actions

github-actions Bot commented May 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4802c1eb89b9b6539dc66d1c104af075fc4ccd57
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/d8de4826-fc9a-40ab-a0d4-5b84fbb8b9d7

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@gantunesr

gantunesr commented May 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Performance tests

Device: Samsung Galaxy A22

Ethereum account creation

// file: app/components/Views/AddAccountActions/AddAccountActions.tsx
// method: addNewHdAccount();
main perf/accounts-improvements
Test 1 2.92 secs 2.20 secs
Test 2 2.98 secs 2.39 secs
Test 3 5.36 secs 4.15 secs
Test 4 5.49 secs 4.09 secs
Test 5 3.14 secs 4.20 secs

Solana account creation

// file: app/components/Views/AddNewAccount/AddNewAccount.tsx
// method: multichainWalletSnapClient.createAccount({ ... });
main perf/accounts-improvements
Test 1 0.63 secs 0.039 secs
Test 2 0.25 secs 0.061 secs
Test 3 0.29 secs 0.11 secs
Test 4 0.36 secs 0.068 secs
Test 5 0.34 secs 0.064 secs

@ccharly ccharly linked an issue May 7, 2025 that may be closed by this pull request
[Bug]: performance degradation during account creation #14864
Closed
@ccharly ccharly force-pushed the perf/accounts-improvements branch from 4802c1e to a8a38bc Compare May 7, 2025 14:59
gantunesr
gantunesr previously approved these changes May 7, 2025
View reviewed changes

@gantunesr gantunesr left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but the CI is still failing

@ccharly ccharly force-pushed the perf/accounts-improvements branch from a8a38bc to 7e834ae Compare May 7, 2025 16:26
@ccharly ccharly added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E and removed Run Smoke E2E labels May 7, 2025
@github-actions

github-actions Bot commented May 7, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 7e834ae
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/dbbaf52a-ab2c-4b3d-8db7-707a3d51a67f

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

ccharly
ccharly commented May 7, 2025
View reviewed changes
Comment thread package.json
@sonarqubecloud

sonarqubecloud Bot commented May 7, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ccharly ccharly added this pull request to the merge queue May 7, 2025
Merged via the queue into main with commit 79a10c6 May 7, 2025
40 checks passed
@ccharly ccharly deleted the perf/accounts-improvements branch May 7, 2025 17:42
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@gantunesr gantunesr gantunesr approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

@ccharly ccharly

Labels

area-performance Issues relating to slowness of app, cpu usage, and/or blank screens. No QA Needed Apply this label when your PR does not need any QA effort. release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-accounts-framework Accounts team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: performance degradation during account creation

4 participants

@ccharly @gantunesr @tommasini @metamaskbot