Skip to content

Chore: upgrade assets controller v60#14913

Merged
sahar-fehri merged 26 commits into
mainfrom
chore/upgrade-assets-controller-v60
May 6, 2025
Merged

Chore: upgrade assets controller v60#14913
sahar-fehri merged 26 commits into
mainfrom
chore/upgrade-assets-controller-v60

Conversation

@salimtb

@salimtb salimtb commented Apr 27, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Upgrade Asset Controllers to v60

This update upgrades the asset controllers to version 59, which introduces important changes to the TokensController:

  • Refactored TokensController to eliminate reliance on a single selected network (#5659).
  • TokensController methods now require networkClientId to be explicitly passed as a parameter.
  • Token management logic is now fully parameterized by chainId, enabling multi-chain token handling and improving reliability across network changes.
  • Internal state updates and token metadata fetching are now scoped to the appropriate chainId.

Related issues

Fixes:

Manual testing steps

  1. Go to MM wallet
  2. Test the assets part ( import token, hide tokens, add tokens ...etc )

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@salimtb salimtb changed the base branch from main to chore/upgrade-assets-controller-v59 April 27, 2025 20:30
@github-actions

github-actions Bot commented Apr 27, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security

socket-security Bot commented Apr 27, 2025 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​assets-controllers@​59.0.0 ⏵ 60.0.093 +210090100 +2100

View full report

@socket-security

socket-security Bot commented Apr 27, 2025 •
edited
Loading

Copy link
Copy Markdown

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@github-actions

github-actions Bot commented Apr 27, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 2d06f00
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/7ac04bff-72b7-4110-a3b2-79eab0127c12

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@salimtb salimtb changed the title Chore/upgrade assets controller v60 Chore: upgrade assets controller v60 Apr 27, 2025
@salimtb salimtb mentioned this pull request Apr 27, 2025
Merged
4 tasks
@salimtb salimtb force-pushed the chore/upgrade-assets-controller-v60 branch from c916548 to 4a31e08 Compare April 28, 2025 23:49
@github-actions

github-actions Bot commented Apr 29, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 4a31e08
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4ce64d17-24d2-406c-aa3f-37e9a6e5a871

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

Base automatically changed from chore/upgrade-assets-controller-v59 to main April 29, 2025 09:40
wachunei
wachunei approved these changes May 6, 2025
View reviewed changes

@wachunei wachunei left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ramp changes LGTM

tommasini
tommasini reviewed May 6, 2025
View reviewed changes

@tommasini tommasini left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that we need to bump accounts controller to v28 to be able to fill the peer dependency of the version 60 of assets controller

@ccharly

ccharly commented May 6, 2025

Copy link
Copy Markdown
Contributor

@tommasini I do have something in stock for this, and actually the 60.0.0 do not need accounts-controller@28.0.0, but the next one will need it (and that's what I'm working on right now 😄)

I'd need to get this one on main first, ideally, so I can do a massive bump of all peer deps of the accounts-controller!

@github-actions

github-actions Bot commented May 6, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 9fe4baa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/b9a1cf6c-a149-4e31-aa0c-2f9b21464304

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud

sonarqubecloud Bot commented May 6, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@sahar-fehri sahar-fehri enabled auto-merge May 6, 2025 18:52
@ccharly ccharly mentioned this pull request May 6, 2025
Merged
8 tasks
@sahar-fehri sahar-fehri added this pull request to the merge queue May 6, 2025
Merged via the queue into main with commit e9ff1dd May 6, 2025
45 of 51 checks passed
@sahar-fehri sahar-fehri deleted the chore/upgrade-assets-controller-v60 branch May 6, 2025 21:29
@github-actions github-actions Bot locked and limited conversation to collaborators May 6, 2025
@metamaskbot metamaskbot added the release-7.47.0 Issue or pull request that will be included in release 7.47.0 label May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sahar-fehri sahar-fehri sahar-fehri left review comments

@wachunei wachunei wachunei approved these changes

@OGPoyraz OGPoyraz OGPoyraz approved these changes

@tommasini tommasini tommasini approved these changes

@infiniteflower infiniteflower infiniteflower approved these changes

Assignees

No one assigned

Labels

release-7.47.0 Issue or pull request that will be included in release 7.47.0 team-assets

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@salimtb @codecov-commenter @ccharly @wachunei @OGPoyraz @sahar-fehri @tommasini @infiniteflower @metamaskbot