Merged
Conversation
Contributor
Author
|
UPDATE
Added:
GABA PRs shouldn't be blockers for this PR to merge, when those PRs are merged we only need to update the version. |
brunobar79
approved these changes
Nov 7, 2018
Contributor
brunobar79
left a comment
There was a problem hiding this comment.
@estebanmino This looks great to me!
Merged
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* new branch app settings with languages selection and reveal seed words working * app settings change current conversion * app settings reset account with new action modal component * changes to app settings view and add custom rpc url * rpc url validation * remove rpc target WIP * delete custom rpc url * persist language and change navbar according to language * update snapshot * reload app when language is changed * update GABA version * eth-block-tracker to v3.0.1 and use of react-native-modal * update unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new app settings view with the following:
For this GIF ganache was running on background to show the ability to add custom RPC url.
Component
RevealPrivateCredentialfrom MetaMask/website#147 was used for revealing seed words. Tests are included there, probably we want to merge that PR first.WIP
Waiting for MetaMask/core#20
Language and currency go back to default when app is turned off.
Checklist
Issue
Resolves #65