Skip to content

chore(runway): cherry-pick fix: deeplinks when non evm network is selected (#14521)#14581

Merged
NicolasMassart merged 1 commit into
release/7.44.0from
runway-cherry-pick-7.44.0-1744284944
Apr 10, 2025
Merged

chore(runway): cherry-pick fix: deeplinks when non evm network is selected (#14521)#14581
NicolasMassart merged 1 commit into
release/7.44.0from
runway-cherry-pick-7.44.0-1744284944

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

…ected (#14521)

## **Description**

This PR fixes the deeplink issue when non evm network is selected.

## **Related issues**

Fixes: ##14474

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**



https://github.com/user-attachments/assets/053746fa-2a2c-4c9e-a73f-bb5206a49893


## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: João Loureiro <175489935+joaoloureirop@users.noreply.github.com>
@runway-github runway-github Bot requested a review from a team as a code owner April 10, 2025 11:35
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Apr 10, 2025
@sonarqubecloud

Copy link
Copy Markdown

@NicolasMassart NicolasMassart changed the title chore(runway): cherry-pick fix: deeplinks when non evm network is selected chore(runway): cherry-pick fix: deeplinks when non evm network is selected (#14521) Apr 10, 2025

@NicolasMassart NicolasMassart left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: this cherry pick matches the original PR.

@NicolasMassart NicolasMassart merged commit f3c7b9a into release/7.44.0 Apr 10, 2025
@NicolasMassart NicolasMassart deleted the runway-cherry-pick-7.44.0-1744284944 branch April 10, 2025 12:04
@github-actions

github-actions Bot commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 7e28a13
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/59d3ee9a-85c8-4691-bf11-816a2f23680d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants