Skip to content

fix: deeplinks when non evm network is selected#14521

Merged
tommasini merged 8 commits into
mainfrom
fix/14517-deeplink-when-non-evm-network-selected
Apr 10, 2025
Merged

fix: deeplinks when non evm network is selected#14521
tommasini merged 8 commits into
mainfrom
fix/14517-deeplink-when-non-evm-network-selected

Conversation

@tommasini

@tommasini tommasini commented Apr 8, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR fixes the deeplink issue when non evm network is selected.

Related issues

Fixes: ##14474

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Screen_Recording_20250408_192958_MetaMask.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@tommasini tommasini added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-mobile-platform Mobile Platform team Run Smoke E2E labels Apr 8, 2025
@tommasini tommasini requested a review from a team as a code owner April 8, 2025 18:33
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Apr 8, 2025
@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Apr 8, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: a999515
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/fbc626c8-ed09-4b7a-8797-ae543df7fa2d

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

owencraston
owencraston previously approved these changes Apr 8, 2025
View reviewed changes
@sethkfman sethkfman linked an issue Apr 8, 2025 that may be closed by this pull request
[Bug]: App crash while being on the Solana network and clicking on an ERC20 payment deep link #14474
Closed
@tommasini tommasini requested a review from a team April 9, 2025 10:34
@github-actions

github-actions Bot commented Apr 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 42a742f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/6770fe91-b61b-4117-9908-3564e450d894

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

zone-live
zone-live previously approved these changes Apr 9, 2025
View reviewed changes
@github-actions

github-actions Bot commented Apr 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: dfa5d62
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/250bf336-c320-4b34-91c3-0e4753b83223

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@codecov-commenter

codecov-commenter commented Apr 9, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.75%. Comparing base (08382bc) to head (dfa5d62).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14521      +/-   ##
==========================================
+ Coverage   66.57%   66.75%   +0.18%     
==========================================
  Files        2257     2259       +2     
  Lines       48273    48335      +62     
  Branches     6823     6835      +12     
==========================================
+ Hits        32139    32268     +129     
+ Misses      14102    14038      -64     
+ Partials     2032     2029       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: ff4d65d
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/39127f42-7cc5-46ac-8cf1-450f89d2855b

Note

  • This comment will auto-update when build completes
  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

joaoloureirop
joaoloureirop reviewed Apr 9, 2025
View reviewed changes
Comment thread app/core/DeeplinkManager/Handlers/handleEthereumUrl.test.ts Outdated
@tommasini @joaoloureirop
Update app/core/DeeplinkManager/Handlers/handleEthereumUrl.test.ts
566f82e 
Co-authored-by: João Loureiro <175489935+joaoloureirop@users.noreply.github.com>
@tommasini tommasini dismissed stale reviews from zone-live and owencraston via 566f82e April 9, 2025 15:10
@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Apr 9, 2025
@github-actions

github-actions Bot commented Apr 9, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 33634fa
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/5ac684b9-5006-4d8b-9d03-a173759149e3

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@Cal-L Cal-L added this pull request to the merge queue Apr 9, 2025
@sethkfman sethkfman removed this pull request from the merge queue due to the queue being cleared Apr 9, 2025
@sonarqubecloud

sonarqubecloud Bot commented Apr 10, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions

github-actions Bot commented Apr 10, 2025 •
edited by metamaskbot
Loading

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: acfda06
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/31837d09-5b76-4030-b184-89ba20f02c67

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@tommasini tommasini added this pull request to the merge queue Apr 10, 2025
Merged via the queue into main with commit 314c84b Apr 10, 2025
@tommasini tommasini deleted the fix/14517-deeplink-when-non-evm-network-selected branch April 10, 2025 11:31
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Apr 10, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 10, 2025
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Apr 10, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@joaoloureirop joaoloureirop joaoloureirop approved these changes

@zone-live zone-live zone-live left review comments

@owencraston owencraston owencraston left review comments

Assignees

No one assigned

Labels

release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: App crash while being on the Solana network and clicking on an ERC20 payment deep link

7 participants

@tommasini @codecov-commenter @zone-live @owencraston @joaoloureirop @gauthierpetetin @metamaskbot