Skip to content

chore(runway): cherry-pick fix: activity reloads every minute (#14465)#14567

Merged
NicolasMassart merged 1 commit into
release/7.44.0from
runway-cherry-pick-7.44.0-1744215304
Apr 9, 2025
Merged

chore(runway): cherry-pick fix: activity reloads every minute (#14465)#14567
NicolasMassart merged 1 commit into
release/7.44.0from
runway-cherry-pick-7.44.0-1744215304

Conversation

@runway-github

@runway-github runway-github Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

Activity was reloading every minute, closing the details modal as the
loading appeared in the screen.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

## **Related issues**

Fixes: #14446

## **Manual testing steps**

1. Go to activity
2. Wait until a minute change on the top of the device
3. Activity should not reload
4.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/272cb2fa-3b84-4b37-947f-bea52764cbf5

### **After**

<!-- [screenshots/recordings] -->


https://github.com/user-attachments/assets/c3e604da-9d36-4a88-9051-ffb727453215

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Daniel Cross <dan.s.cross@icloud.com>
Co-authored-by: Antonio Regadas <antonio.regadas@consensys.net>
@runway-github runway-github Bot requested a review from a team as a code owner April 9, 2025 16:13
@NicolasMassart NicolasMassart changed the title chore(runway): cherry-pick fix: activity reloads every minute chore(runway): cherry-pick fix: activity reloads every minute (#14465) Apr 9, 2025
@NicolasMassart NicolasMassart enabled auto-merge (squash) April 9, 2025 16:16
@metamaskbot metamaskbot added the team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead label Apr 9, 2025
@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown
Contributor

https://bitrise.io/ Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 28057c9
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/4313860f-7088-4198-b6a9-0aea497648f1

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

  • Check the documentation if you have any doubts on how to understand the failure on bitrise

@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2025

Copy link
Copy Markdown

@NicolasMassart NicolasMassart merged commit 5c653b5 into release/7.44.0 Apr 9, 2025
@NicolasMassart NicolasMassart deleted the runway-cherry-pick-7.44.0-1744215304 branch April 9, 2025 17:45
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-runway-bot-deprecated DEPRECATED: please use "team-bots" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants