Skip to content

fix: activity reloads every minute#14465

Merged
aganglada merged 11 commits into
mainfrom
fix/activity-reloads
Apr 8, 2025
Merged

fix: activity reloads every minute#14465
aganglada merged 11 commits into
mainfrom
fix/activity-reloads

Conversation

@aganglada

@aganglada aganglada commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

Description

Activity was reloading every minute, closing the details modal as the loading appeared in the screen.

Related issues

Fixes: #14446

Manual testing steps

  1. Go to activity
  2. Wait until a minute change on the top of the device
  3. Activity should not reload

Screenshots/Recordings

Before

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-05.at.14.47.06.mp4

After

Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-04-05.at.14.48.08.mp4

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@aganglada aganglada self-assigned this Apr 5, 2025
@aganglada aganglada requested a review from a team as a code owner April 5, 2025 12:53
@github-actions

github-actions Bot commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the team-networks Networks team label Apr 5, 2025
@codecov-commenter

codecov-commenter commented Apr 5, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.43%. Comparing base (44bb493) to head (c1c9ea2).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14465      +/-   ##
==========================================
+ Coverage   66.29%   66.43%   +0.13%     
==========================================
  Files        2248     2248              
  Lines       48037    48050      +13     
  Branches     6766     6783      +17     
==========================================
+ Hits        31848    31920      +72     
+ Misses      14172    14103      -69     
- Partials     2017     2027      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aganglada aganglada added QA Passed QA testing has been completed and passed No E2E Smoke Needed labels Apr 7, 2025
zone-live
zone-live previously approved these changes Apr 7, 2025
View reviewed changes
@aganglada aganglada enabled auto-merge April 7, 2025 10:38
Daniel-Cross
Daniel-Cross reviewed Apr 7, 2025
View reviewed changes
Comment thread app/components/Views/MultichainTransactionsView/MultichainTransactionsView.tsx Outdated
Daniel-Cross
Daniel-Cross reviewed Apr 7, 2025
View reviewed changes
Comment thread app/components/Views/MultichainTransactionsView/MultichainTransactionsView.tsx Outdated
@aganglada @Daniel-Cross
Update app/components/Views/MultichainTransactionsView/MultichainTran…
2fd855c 
…sactionsView.tsx

Co-authored-by: Daniel Cross <dan.s.cross@icloud.com>
@aganglada aganglada dismissed stale reviews from javiergarciavera and zone-live via 2fd855c April 8, 2025 09:49
@aganglada aganglada requested review from a team as code owners April 8, 2025 11:22
@aganglada aganglada requested a review from a team April 8, 2025 11:22
@aganglada aganglada force-pushed the fix/activity-reloads branch from 970cc0d to 27a9d5c Compare April 8, 2025 11:23
@aganglada aganglada removed request for a team April 8, 2025 11:24
zone-live
zone-live previously approved these changes Apr 8, 2025
View reviewed changes
Daniel-Cross
Daniel-Cross previously approved these changes Apr 8, 2025
View reviewed changes

@Daniel-Cross Daniel-Cross left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@zone-live zone-live dismissed stale reviews from Daniel-Cross, javiergarciavera, and themself via 279671b April 8, 2025 12:39
zone-live
zone-live previously approved these changes Apr 8, 2025
View reviewed changes
Daniel-Cross
Daniel-Cross previously approved these changes Apr 8, 2025
View reviewed changes
@zone-live zone-live dismissed stale reviews from Daniel-Cross, javiergarciavera, and themself via ae18140 April 8, 2025 14:12
@sonarqubecloud

sonarqubecloud Bot commented Apr 8, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aganglada aganglada added this pull request to the merge queue Apr 8, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 8, 2025
@aganglada aganglada added this pull request to the merge queue Apr 8, 2025
Merged via the queue into main with commit bbeffa0 Apr 8, 2025
@aganglada aganglada deleted the fix/activity-reloads branch April 8, 2025 16:18
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 8, 2025
@metamaskbot metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zone-live zone-live zone-live approved these changes

@javiergarciavera javiergarciavera javiergarciavera approved these changes

+1 more reviewer

@Daniel-Cross Daniel-Cross Daniel-Cross approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@aganglada aganglada

Labels

QA Passed QA testing has been completed and passed release-7.45.0 Issue or pull request that will be included in release 7.45.0 team-networks Networks team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Activity list reloads every minute

6 participants

@aganglada @codecov-commenter @zone-live @Daniel-Cross @javiergarciavera @metamaskbot