chore(runway): cherry-pick 2ab39eb (#14475)#14483
Merged
NicolasMassart merged 8 commits intoApr 9, 2025
Merged
Conversation
… in Snaps UI [cp-7.44.0] (#14475) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Prevent re-renders of the Field component in Snaps UI which would make the keyboard briefly disappear. Since `Field` does not actually map to have any children (as it instead passes some components as props), we do not want the default key generation behavior. Instead, this PR introduces specific logic for fields. ## **Related issues** Fixes: MetaMask/snaps#3308
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This comment was marked as outdated.
This comment was marked as outdated.
NicolasMassart
approved these changes
Apr 9, 2025
Contributor
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/7.44.0 #14483 +/- ##
=================================================
Coverage ? 65.74%
=================================================
Files ? 2229
Lines ? 47408
Branches ? 6687
=================================================
Hits ? 31168
Misses ? 14247
Partials ? 1993 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent re-renders of the Field component in Snaps UI which would make
the keyboard briefly disappear. Since
Fielddoes not actually map tohave any children (as it instead passes some components as props), we do
not want the default key generation behavior. Instead, this PR
introduces specific logic for fields.
Related issues
Fixes: MetaMask/snaps#3308 2ab39eb