fix: cp-7.44.0 Prevent re-renders of Field component in Snaps UI#14475
Merged
Conversation
Mrtenz
previously approved these changes
Apr 7, 2025
Contributor
|
|
Mrtenz
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent re-renders of the Field component in Snaps UI which would make the keyboard briefly disappear. Since
Fielddoes not actually map to have any children (as it instead passes some components as props), we do not want the default key generation behavior. Instead, this PR introduces specific logic for fields.Related issues
Fixes: MetaMask/snaps#3308