test: add back `@testing-library/react-native` concurrentRoot in tests. by Prithpal-Sooriya · Pull Request #14454 · MetaMask/metamask-mobile

Prithpal-Sooriya · 2025-04-04T19:42:07Z

Description

As described in this PR #14450.

NEW FEATURES - CONCURRENT RENDERING
This adds support for React 18 concurrent rendering. Even if we don't support react 18, it will help us write better components and tests that handle:

prop & selector changes

useEffects

loading states

This PR adds back concurrentRoot in our react-native tests, and fixes tests that fail due to async behaviours.

Related issues

Fixes:

Manual testing steps

Ensure unit tests all pass

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2025-04-04T19:42:21Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

…de-testing-library-react-native-concurrent-root-fixes

github-actions · 2025-04-07T20:57:59Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3d1e22f
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/690f0a9e-e461-444e-be00-c307ff5fc86c

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

codecov-commenter · 2025-04-07T21:08:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.43%. Comparing base (44bb493) to head (3d1e22f).
Report is 31 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14454      +/-   ##
==========================================
+ Coverage   66.29%   66.43%   +0.13%     
==========================================
  Files        2248     2251       +3     
  Lines       48037    48093      +56     
  Branches     6766     6774       +8     
==========================================
+ Hits        31848    31950     +102     
+ Misses      14172    14125      -47     
- Partials     2017     2018       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ent-root-fixes

github-actions · 2025-04-08T11:36:06Z

Bitrise

🔄🔄🔄 pr_smoke_e2e_pipeline started on Bitrise...🔄🔄🔄

Commit hash: fb42b16
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c0572cd0-e8c4-488a-9443-315ab68e1c08

Note

This comment will auto-update when build completes
You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

this improves test to prevent null elements

github-actions · 2025-04-08T11:44:24Z

Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 524f643
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/28ee3cc3-c89d-4106-b0c1-71970d09b24f

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

sonarqubecloud · 2025-04-08T11:57:28Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

NicolasMassart

New matchers 🎉 Thanks!

OGPoyraz

Confirmation changes LGTM

Prithpal-Sooriya added 3 commits April 4, 2025 19:22

feat: upgrade @testing-library/react-native

0825539

fix: fix lint issues

a236509

fix: fix tests failing with concurrent root

b229d00

metamaskbot added the team-assets label Apr 4, 2025

Prithpal-Sooriya mentioned this pull request Apr 4, 2025

feat: upgrade @testing-library/react-native to 13.2.0 #14450

Merged

7 tasks

Prithpal-Sooriya added the DO-NOT-MERGE Pull requests that should not be merged label Apr 4, 2025

fix: fix more failing tests

b6d1541

Prithpal-Sooriya changed the title ~~Upgrade testing library react native concurrent root fixes~~ TEMP: testing library react native concurrent root fixes Apr 4, 2025

fix: failing concurrent root test failues

b5e5f02

Prithpal-Sooriya commented Apr 4, 2025

View reviewed changes

Comment thread app/components/UI/PaymentRequest/index.test.tsx

Prithpal-Sooriya commented Apr 4, 2025

View reviewed changes

Comment thread .../components/Confirm/Info/TypedSignV3V4/Simulation/TypedSignDecoded/TypedSignDecoded.test.tsx

Prithpal-Sooriya commented Apr 4, 2025

View reviewed changes

Comment thread app/components/Views/MultichainTransactionsView/MultichainTransactionsView.test.tsx

Prithpal-Sooriya commented Apr 7, 2025

View reviewed changes

Comment thread app/components/UI/SolanaNewFeatureContent/SolanaNewFeatureContent.tsx Outdated

Prithpal-Sooriya changed the title ~~TEMP: testing library react native concurrent root fixes~~ test: testing library react native concurrent root fixes Apr 7, 2025

Prithpal-Sooriya added 4 commits April 7, 2025 21:38

Merge branch 'main' of github.com:MetaMask/metamask-mobile into upgra…

877ff11

…de-testing-library-react-native-concurrent-root-fixes

test: remove temporary concurrentRoot in test setup

8474a4a

fix: solana banner infinite close bug

d5a74f2

test: rename test

3d1e22f

Prithpal-Sooriya marked this pull request as ready for review April 7, 2025 20:54

Prithpal-Sooriya requested review from a team as code owners April 7, 2025 20:54

Prithpal-Sooriya changed the title ~~test: testing library react native concurrent root fixes~~ test: add back @testing-library/react-native concurrentRoot in tests. Apr 7, 2025

Prithpal-Sooriya added the Run Smoke E2E label Apr 7, 2025

Merge branch 'main' into upgrade-testing-library-react-native-concurr…

fb42b16

…ent-root-fixes

Prithpal-Sooriya added Run Smoke E2E and removed Run Smoke E2E labels Apr 8, 2025

Prithpal-Sooriya removed the DO-NOT-MERGE Pull requests that should not be merged label Apr 8, 2025

Prithpal-Sooriya commented Apr 8, 2025

View reviewed changes

Comment thread app/components/UI/SolanaNewFeatureContent/SolanaNewFeatureContent.tsx

test: update test to use toBeOnTheScreen instead of toBeDefined

524f643

this improves test to prevent null elements

Prithpal-Sooriya added Run Smoke E2E and removed Run Smoke E2E labels Apr 8, 2025

metamaskbot added the bitrise-result-ready label Apr 8, 2025

github-actions Bot removed the bitrise-result-ready label Apr 8, 2025

sahar-fehri approved these changes Apr 8, 2025

View reviewed changes

NicolasMassart approved these changes Apr 8, 2025

View reviewed changes

FrederikBolding approved these changes Apr 8, 2025

View reviewed changes

Prithpal-Sooriya enabled auto-merge April 8, 2025 13:34

OGPoyraz approved these changes Apr 8, 2025

View reviewed changes

Prithpal-Sooriya added this pull request to the merge queue Apr 8, 2025

Merged via the queue into main with commit 0751682 Apr 8, 2025

Prithpal-Sooriya deleted the upgrade-testing-library-react-native-concurrent-root-fixes branch April 8, 2025 13:55

github-actions Bot locked and limited conversation to collaborators Apr 8, 2025

metamaskbot added the release-7.45.0 Issue or pull request that will be included in release 7.45.0 label Apr 8, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: add back `@testing-library/react-native` concurrentRoot in tests.#14454

test: add back `@testing-library/react-native` concurrentRoot in tests.#14454
Prithpal-Sooriya merged 11 commits into
mainfrom
upgrade-testing-library-react-native-concurrent-root-fixes

Prithpal-Sooriya commented Apr 4, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Apr 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2025 •

edited by metamaskbot

Loading

Uh oh!

codecov-commenter commented Apr 7, 2025

Uh oh!

github-actions Bot commented Apr 8, 2025

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2025 •

edited by metamaskbot

Loading

Uh oh!

sonarqubecloud Bot commented Apr 8, 2025

Uh oh!

NicolasMassart left a comment

Uh oh!

OGPoyraz left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Uh oh!

Conversation

Prithpal-Sooriya commented Apr 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Apr 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot commented Apr 7, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

codecov-commenter commented Apr 7, 2025

Codecov Report

Uh oh!

github-actions Bot commented Apr 8, 2025

Bitrise

Uh oh!

Uh oh!

github-actions Bot commented Apr 8, 2025 • edited by metamaskbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bitrise

Uh oh!

sonarqubecloud Bot commented Apr 8, 2025

Quality Gate passed

Uh oh!

NicolasMassart left a comment

Choose a reason for hiding this comment

Uh oh!

OGPoyraz left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Prithpal-Sooriya commented Apr 4, 2025 •

edited

Loading

github-actions Bot commented Apr 7, 2025 •

edited by metamaskbot

Loading

github-actions Bot commented Apr 8, 2025 •

edited by metamaskbot

Loading