Description

This upgrades @testing-library/react-native to v13!

Followed the migration guide here. It seems to not impact us.

NEW FEATURES - JEST MATCHERS
https://callstack.github.io/react-native-testing-library/docs/api/jest-matchers

As long as you have imported something from '@testing-library/react-native', you will get extended jest matchers to write more accurate and easier to read assertions!

// This is bad since an element returned can be `null`, which is technically an object!
expect(component).toBeDefined()

// This is okay, but can still have false positives (e.g. `0 && <>` shortcuts)
// It is also really weird and hard to understand when first looking at it.
expect(component).toBeTruthy()

// NOW we can target elements on screen. A more easy to read/understand syntax
// Look through the other extended jest matchers we can also utilise: https://callstack.github.io/react-native-testing-library/docs/api/jest-matchers
expect(component).toBeOnTheScreen();

NEW FEATURES - CONCURRENT RENDERING
This adds support for React 18 concurrent rendering. Even if we don't support react 18, it will help us write better components and tests that handle:

• prop & selector changes
• useEffects
• loading states

Related issues

Fixes:

Manual testing steps

Ensure that our existing test suite passes.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.